Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): change ResourceType Type for AWS Inline Policy Check #3599

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

gabrielsoltz
Copy link
Contributor

Context

Hello Heroes!

The check iam_inline_policy_no_administrative_privileges is incorrectly defined as ASFF Type AwsIamPolicy...
Inline Policies are not an AWS Resource itself. Instead, they are part of an IAM Role.
The correct Type for this check is AwsIamRole; we are evaluating IAM Inline policies in a Role.
This became obvious when comparing with the ID that we have as the output of the same check, it's the IAM Role ARN (arn:aws:iam::XXXXXXXX:role/ROLE_NAME).

Thanks!

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gabrielsoltz gabrielsoltz requested a review from a team March 23, 2024 10:54
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (41e0a21) to head (8cb8fc0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3599   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files         699      699           
  Lines       21574    21574           
=======================================
  Hits        18577    18577           
  Misses       2997     2997           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar changed the title Fix ASFF Type for Inline Policy Check (iam_inline_policy_no_administrative_privileges) fix(metadata): change ResourceType Type for AWS Inline Policy Check Mar 25, 2024
Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks @gabrielsoltz

@sergargar sergargar merged commit 4932ccc into prowler-cloud:master Mar 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants