Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Multiple dashboard fixes #3654

Merged
merged 7 commits into from
Apr 4, 2024
Merged

fix(Dashboard): Multiple dashboard fixes #3654

merged 7 commits into from
Apr 4, 2024

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Apr 3, 2024

Context

This pr adds some fixes for dashboards:

  • Handle only v3 outputs for aws
  • Fix download button
  • Move "Subscribe..." from the nav to the bottom

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v4@1e001bb). Click here to learn what that means.

❗ Current head 4e876cf differs from pull request most recent head 97db285. Consider uploading reports for the commit 97db285 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##             v4    #3654   +/-   ##
=====================================
  Coverage      ?   85.90%           
=====================================
  Files         ?      722           
  Lines         ?    22433           
  Branches      ?        0           
=====================================
  Hits          ?    19271           
  Misses        ?     3162           
  Partials      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedrooot pedrooot marked this pull request as ready for review April 3, 2024 21:18
@pedrooot pedrooot requested a review from a team April 3, 2024 21:18
Copy link
Contributor

github-actions bot commented Apr 4, 2024

You can check the documentation for this PR here -> SaaS Documentation

@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider github_actions Pull requests that update GitHub Actions code labels Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

You can check the documentation for this PR here -> SaaS Documentation

@sergargar sergargar merged commit ef3a0f4 into v4 Apr 4, 2024
2 checks passed
@sergargar sergargar deleted the dashboard-fixes branch April 4, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation github_actions Pull requests that update GitHub Actions code provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants