docs(mutelist): remove MUTED and explain new fields #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
sergargar
reviewed
Apr 9, 2024
| @@ -108,23 +114,23 @@ If you want to mute failed findings only in specific regions, create a file with | |||
| Resources: | |||
| - "*" | |||
|
|
|||
| ## Default AWS Mutelist | |||
| ### Default Mutelist | |||
There was a problem hiding this comment.
I would not remove AWS, since the default mutelist is only available for AWS
There was a problem hiding this comment.
The same again, I've included an AWS section to enclose this.
sergargar
reviewed
Apr 9, 2024
| For the AWS Provider, Prowler is executed with a Default AWS Mutelist with the AWS Resources that should be muted such as all resources created by AWS Control Tower when setting up a landing zone. | ||
| You can see this Mutelist file in [`prowler/config/aws_mutelist.yaml`](https://github.com/prowler-cloud/prowler/blob/master/prowler/config/aws_allowlist.yaml). | ||
|
|
||
| ## Supported AWS Mutelist Locations | ||
| ### Supported Mutelist Locations |
There was a problem hiding this comment.
I would not remove AWS, since this locations are only available for AWS Mutelists
There was a problem hiding this comment.
This is within a new AWS section.
sergargar
deleted the
PRWLR-3485-docs-remove-muted-from-mutelist-documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since Prowler v4,
WARNINGorMUTEDare not valid statuses, the finding has amutedattribute to store if muted or not.Description
MUTED is not valid status anymore. Remove it from the documentation.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.