chore(cis): add CIS output class #4400
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4400 +/- ##
==========================================
+ Coverage 87.62% 87.71% +0.08%
==========================================
Files 851 853 +2
Lines 26596 26624 +28
==========================================
+ Hits 23306 23353 +47
+ Misses 3290 3271 -19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
What a great piece of work @sergargar please review my comments when you get a chance, we are closer to the finish line 🏁
| content = content.removeprefix("\r\n") | ||
| content = content.removesuffix("\r\n") |
There was a problem hiding this comment.
| content = content.removeprefix("\r\n") | |
| content = content.removesuffix("\r\n") |
| content = mock_file.read() | ||
| content = content.removeprefix("\r\n") | ||
| content = content.removesuffix("\r\n") | ||
| assert CIS_1_4_AWS.Description in content |
There was a problem hiding this comment.
You have to check all the fields within the output. Check the CSV tests.
There was a problem hiding this comment.
The comments from tests/lib/outputs/compliance/cis_aws_test.py applies here.
There was a problem hiding this comment.
The comments from tests/lib/outputs/compliance/cis_aws_test.py applies here.
There was a problem hiding this comment.
The comments from tests/lib/outputs/compliance/cis_aws_test.py applies here.
github-actions
bot
added
the
provider/kubernetes
…-output-object-from-a-list-of-findings
|
All comments solved, thanks for the review @jfagoagas ! |
sergargar
deleted the
PRWLR-3949-generate-the-generic-compliance-output-object-from-a-list-of-findings
branch
Description
Generate the CIS Compliance output object from a list of findings
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.