feat(elasticbeanstalk): add new check elasticbeanstalk_enhanced_health_reporting_enabled
#5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attributes and fix test to adjust to the changes
…d list_tags_for_resource
Base automatically changed from
PRWLR-4315-create-new-service-for-elastic-beanstalk
to
master
October 9, 2024 13:29
MarioRgzLpz
changed the title
elasticbeanstalk_enhanced_health_reporting_enabled
…should-have-enhanced-health-reporting-enabled
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5348 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 1022 1023 +1
Lines 31382 31434 +52
=======================================
+ Hits 28044 28091 +47
- Misses 3338 3343 +5 ☔ View full report in Codecov by Sentry. |
sergargar
reviewed
Oct 11, 2024
Comment on lines
19
to
22
| if ( | ||
| environment.health_reporting is None | ||
| or environment.health_reporting != "enhanced" | ||
| ): |
There was a problem hiding this comment.
Suggested change
| if ( | |
| environment.health_reporting is None | |
| or environment.health_reporting != "enhanced" | |
| ): | |
| if environment.health_reporting != "enhanced": |
sergargar
reviewed
Oct 11, 2024
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "Provider": "aws", | |||
| "CheckID": "elasticbeanstalk_enhanced_health_reporting_enabled", | |||
There was a problem hiding this comment.
Suggested change
| "CheckID": "elasticbeanstalk_enhanced_health_reporting_enabled", | |
| "CheckID": "elasticbeanstalk_environment_enhanced_health_reporting", |
sergargar
approved these changes
Oct 11, 2024
sergargar
deleted the
PRWLR-4510-elastic-beanstalk-environments-should-have-enhanced-health-reporting-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a new check to make sure enhanced health reporting is enabled for AWS Elastic Beanstalk environments. The control fails if enhanced health reporting is not enabled.
Enhanced health reporting provides a more detailed view of the health of the underlying infrastructure, allowing for quicker responses to changes that could affect application availability. It helps gauge the severity of issues and pinpoint possible causes by evaluating logs and metrics from environment EC2 instances.
Description
Added a new check
elasticbeanstalk_enhanced_health_reporting_enabledwith respective unit tests and metadata.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.