feat(codebuild): add new check codebuild_project_logging_enabled
#5365
+379
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
puchy22
changed the base branch from
master
to
PRWLR-4460-ensure-code-build-s-3-logs-are-encrypted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5365 +/- ##
==========================================
- Coverage 89.45% 89.21% -0.24%
==========================================
Files 1035 1038 +3
Lines 31784 32033 +249
==========================================
+ Hits 28432 28579 +147
- Misses 3352 3454 +102 ☔ View full report in Codecov by Sentry. |
…to PRWLR-4462-ensure-code-build-project-environments-have-logging-enabled
Base automatically changed from
PRWLR-4460-ensure-code-build-s-3-logs-are-encrypted
to
master
October 14, 2024 18:40
…onments-have-logging-enabled
sergargar
reviewed
Oct 14, 2024
| "ResourceIdTemplate": "arn:partition:service:region:account-id:resource-id", | ||
| "Severity": "medium", | ||
| "ResourceType": "AwsCodeBuildProject", | ||
| "Description": "From a security perspective, logging is an important feature to enable for future forensics efforts in the case of any security incidents. Correlating anomalies in CodeBuild projects with threat detections can increase confidence in the accuracy of those threat detections.", |
There was a problem hiding this comment.
Make the description shorter please, and add that info in the risk.
sergargar
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Can you show in the status extended where are the logs enabled? (In which S3 bucket, CW log group or both)
sergargar
requested changes
Oct 14, 2024
…logging-enabled' of github.com:prowler-cloud/prowler into PRWLR-4462-ensure-code-build-project-environments-have-logging-enabled
sergargar
approved these changes
Oct 15, 2024
sergargar
deleted the
PRWLR-4462-ensure-code-build-project-environments-have-logging-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Check if CodeBuild has logging enabled.
Description
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.