Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): add new check codebuild_report_group_export_encrypted #5384

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Oct 11, 2024

Context

Checks if CodeBuild report group exports are encrypted at rest.

Description

  • Add report_groups to CodeBuild
  • Add ReportGroup and ExportConfig model
  • Test report_groups
  • Add check logic
  • Add unit testing for the check

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 11, 2024 13:58
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 11, 2024
@puchy22 puchy22 changed the base branch from master to PRWLR-4460-ensure-code-build-s-3-logs-are-encrypted October 11, 2024 13:59
@puchy22 puchy22 changed the base branch from PRWLR-4460-ensure-code-build-s-3-logs-are-encrypted to PRWLR-4462-ensure-code-build-project-environments-have-logging-enabled October 11, 2024 13:59
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.22%. Comparing base (aac6038) to head (14c43a1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...viders/aws/services/codebuild/codebuild_service.py 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
+ Coverage   89.20%   89.22%   +0.01%     
==========================================
  Files        1038     1039       +1     
  Lines       32033    32089      +56     
==========================================
+ Hits        28576    28632      +56     
  Misses       3457     3457              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from PRWLR-4462-ensure-code-build-project-environments-have-logging-enabled to master October 15, 2024 11:42
@sergargar sergargar merged commit 78d2fb9 into master Oct 15, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-4803-code-build-report-group-exports-should-be-encrypted-at-rest branch October 15, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants