feat(bedrock): add checks for guardrails configuration and log encryption #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-on-aws-gen-ai-service
…ng-on-aws-gen-ai-service
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5385 +/- ##
========================================
Coverage 89.43% 89.44%
========================================
Files 1027 1030 +3
Lines 31531 31641 +110
========================================
+ Hits 28200 28301 +101
- Misses 3331 3340 +9 ☔ View full report in Codecov by Sentry. |
puchy22
requested changes
Oct 14, 2024
| for filter in guardrail_info.get("contentPolicy", {}).get("filters", []): | ||
| if filter.get("type") == "PROMPT_ATTACK": | ||
| guardrail.prompt_attack_filter_strength = filter.get( | ||
| "inputStrength", None |
There was a problem hiding this comment.
Suggested change
| "inputStrength", None | |
| "inputStrength", "NONE" |
| ) | ||
|
|
||
|
|
||
| def mock_make_api_call(self, operation_name, kwarg): |
There was a problem hiding this comment.
I believe that functions should use a name more characteristic of their behaviour than v2 and v3.
| return make_api_call(self, operation_name, kwarg) | ||
|
|
||
|
|
||
| def mock_make_api_call_v2(self, operation_name, kwarg): |
There was a problem hiding this comment.
Suggested change
| def mock_make_api_call_v2(self, operation_name, kwarg): | |
| def mock_make_api_call_no_filters(self, operation_name, kwarg): |
| return make_api_call(self, operation_name, kwarg) | ||
|
|
||
|
|
||
| def mock_make_api_call_v3(self, operation_name, kwarg): |
There was a problem hiding this comment.
Suggested change
| def mock_make_api_call_v3(self, operation_name, kwarg): | |
| def mock_make_api_call_filter_strength_low(self, operation_name, kwarg): |
| ) | ||
|
|
||
|
|
||
| def mock_make_api_call(self, operation_name, kwarg): |
There was a problem hiding this comment.
Please could change all the mock_make_api_call_vX in all tests for more descriptive names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses security concerns for Amazon Bedrock by introducing three new checks to strengthen protection against prompt attacks, sensitive data exposure, and log security. These checks aim to mitigate the risks associated with generative AI infrastructures being targeted by adversaries.
Description
This PR adds the following three checks:
bedrock_guardrail_prompt_attack_filter_enabledEnsures the prompt attack filter is set to the highest strength to protect models from malicious prompts.
bedrock_guardrail_sensitive_information_filter_enabledVerifies sensitive information filters are enabled to prevent data leakage in model outputs.
bedrock_model_invocation_logs_encryption_enabledEnsures invocation logs are encrypted with AWS KMS to protect sensitive log data from unauthorized access.
These checks enhance Bedrock's security and data protection.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.