Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opensearch): add new check opensearch_domain_master_nodes_fault_tolerant #5393

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

puchy22
Copy link
Member

@puchy22 puchy22 commented Oct 14, 2024

Context

Check if OpenSearch domain has at least three master nodes.

Description

  • Add Master Node attributes to domain
  • Test new domain attributes
  • Add check logic
  • Add unit testing for the check

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@puchy22 puchy22 requested review from a team as code owners October 14, 2024 10:59
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (bc1e6c0) to head (af45092).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
- Coverage   89.18%   89.16%   -0.03%     
==========================================
  Files        1037     1038       +1     
  Lines       32004    32027      +23     
==========================================
+ Hits        28544    28556      +12     
- Misses       3460     3471      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergargar sergargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this check to be like the check opensearch_service_domains_fault_tolerant_data_nodes, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants