-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(waf): add new check waf_regional_rule_with_conditions
#5411
Merged
sergargar
merged 17 commits into
master
from
PRWLR-4448-ensure-aws-waf-classic-regional-rules-have-at-least-one-condition
Oct 16, 2024
Merged
feat(waf): add new check waf_regional_rule_with_conditions
#5411
sergargar
merged 17 commits into
master
from
PRWLR-4448-ensure-aws-waf-classic-regional-rules-have-at-least-one-condition
Oct 16, 2024
+226
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o PRWLR-4454-ensure-aws-waf-classic-regional-web-ac-ls-have-at-least-one-rule-or-rule-group
…o PRWLR-4454-ensure-aws-waf-classic-regional-web-ac-ls-have-at-least-one-rule-or-rule-group
github-actions
bot
added
the
provider/aws
Issues/PRs related with the AWS provider
label
Oct 15, 2024
sergargar
reviewed
Oct 15, 2024
...ler/providers/aws/services/waf/waf_rule_has_conditions/waf_rule_has_conditions.metadata.json
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Oct 15, 2024
...ler/providers/aws/services/waf/waf_rule_has_conditions/waf_rule_has_conditions.metadata.json
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Oct 15, 2024
prowler/providers/aws/services/waf/waf_rule_has_conditions/waf_rule_has_conditions.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Oct 15, 2024
prowler/providers/aws/services/waf/waf_rule_has_conditions/waf_rule_has_conditions.py
Outdated
Show resolved
Hide resolved
sergargar
reviewed
Oct 15, 2024
sergargar
reviewed
Oct 15, 2024
Resolved comments and added total structure for WAFRegional
HugoPBrito
changed the title
feat(WAF): add new check
feat(WAF): add new check Oct 16, 2024
waf_rule_has_conditions
waf_regional_rule_with_conditions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5411 +/- ##
==========================================
+ Coverage 89.22% 89.29% +0.07%
==========================================
Files 1047 1048 +1
Lines 32423 32441 +18
==========================================
+ Hits 28929 28969 +40
+ Misses 3494 3472 -22 ☔ View full report in Codecov by Sentry. |
…-rules-have-at-least-one-condition
sergargar
changed the title
feat(WAF): add new check
feat(waf): add new check Oct 16, 2024
waf_regional_rule_with_conditions
waf_regional_rule_with_conditions
sergargar
approved these changes
Oct 16, 2024
sergargar
deleted the
PRWLR-4448-ensure-aws-waf-classic-regional-rules-have-at-least-one-condition
branch
October 16, 2024 16:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AWS WAF Classic Regional rules
allow users to define specific conditions for monitoring and controlling HTTP(S) requests in their region-based applications. A rule should include at least one condition, such as inspecting the origin, headers, or body of requests, to perform the intended action, like blocking or allowing traffic. Ensuring thatWAF rules
are not empty is vital for the security and functionality of these applications.Description
This check verifies whether an
AWS WAF Classic Regional rule
contains at least one condition. The check fails if no conditions are present within the rule.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.