Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch): add new check cloudwatch_alarm_actions_enabled #5416

Conversation

danibarranqueroo
Copy link
Member

Context

This check ensures that CloudWatch alarm actions are enabled (ActionEnabled should be set to true). The check fails if any CloudWatch alarm action is deactivated. Without active alarm actions, you may not be alerted to security or operational issues, potentially leading to delayed responses and increased risk.

Description

Added new check cloudwatch_alarm_actions_enabled with its unit tests.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danibarranqueroo danibarranqueroo requested review from a team as code owners October 15, 2024 10:46
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.24%. Comparing base (bc1e6c0) to head (52bbad6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5416      +/-   ##
==========================================
+ Coverage   89.18%   89.24%   +0.05%     
==========================================
  Files        1037     1040       +3     
  Lines       32004    32108     +104     
==========================================
+ Hits        28544    28655     +111     
+ Misses       3460     3453       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergargar sergargar merged commit 23c3884 into master Oct 15, 2024
11 checks passed
@sergargar sergargar deleted the PRWLR-4301-add-new-cloud-watch-check-to-ensure-alarm-actions-are-activated branch October 15, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants