🚧 WIP: Steel sheet check #4832

3d-gussner · 2025-01-08T15:05:41Z

Thanks @jfestrada for the idea in #4569.

This is a different approach for this request.

We have the https://help.prusa3d.com/materials (which is missing the PP powder coated steel sheet) and we could use it to warn users when they start to print:

ToDos:

Bit check M862.7 P
And an additional M862.7 parameter Warn with same bit based value
- Example:
- PLA : M862.7 P7 W0 PLA is compatible on Smooth, Textured and Satin, no additional warnings BUT NOT compatible on NylonPA and PP
- ASA: M862.7 P4 W3 ASA is compatible on Satin, warning to use glue stick on Smooth and Textured and BUT NOT compatible on NylonPA
In case there is a warning or stop print send also an //action:notification to inform host users.

In PrusaConnect we already have some sheet information

Post release tasks:

Update doxygen documentation
Update RepRap Gcode wiki
PrusaSlicer profiles PR for MK2.5/S and MK3/S/+

Test PR:

In PrusaSlicer 2.9.0 -> Printer Tab -> Custom G-code -> Start G-code add below

M862.3 P "[printer_model]" ; printer model check
M862.1 P[nozzle_diameter] ; nozzle diameter check

following lines

;Sheet compatibility see https://help.prusa3d.com/materials

;Smooth   1
;Textured 2
;Satin    4
;Nylon    8
;PP       16
;Custom   32

; P<value> compatible                 W<value> warning, like "with glue stick"
;      SMO TXT SAT NYL PP  CUS         SMO TXT SAT NYL PP  CUS
;PLA :P 1 + 2 + 4              = 7  | W                        = 0
;PET :P     2 + 4 + 8          = 14 | W 1                      = 1
;ASA :P         4              = 4  | W 1 + 2                  = 3
;ABS :P         4              = 4  | W 1 + 2                  = 3
;PC  :P         4              = 4  | W 1 + 2                  = 3
;CPE :P     2 + 4              = 6  | W 1                      = 1
;PVA :P 1 + 2 + 4              = 7  | W                        = 0
;BVOH:P 1 + 2 + 4              = 7  | W                        = 0
;HIPS:P 1 + 2 + 4              = 7  | W                        = 0
;PP  :P                16      = 16 | W 1                      = 1
;FLEX:P     2                  = 2  | W 1     + 4              = 5
;NGEN:P     2 + 4              = 6  | W 1                      = 1
;PA  :P             8          = 8  | W     2 + 4              = 6
;Wood:P         4              = 4  | W                        = 0
;PVB :P 1     + 4              = 5  | W                        = 0
;PEI :P             8          = 8  | W     2                  = 2

M862.7 P{if filament_type[initial_tool] == "FLEX"}2{elsif filament_type[initial_tool] == "ASA" or filament_type[initial_tool] == "ABS" or filament_type[initial_tool] == "PC" or filament_type[initial_tool] == "WOOD"}4{elsif filament_type[initial_tool] == "PVB"}5{elsif filament_type[initial_tool] == "CPE" or filament_type[initial_tool] == "NGEN"}6{elsif filament_type[initial_tool] == "PLA" or filament_type[initial_tool] == "PVA" or filament_type[initial_tool] == "BVOH" or filament_type[initial_tool] == "HIPS" }7{elsif filament_type[initial_tool] == "PA" or filament_type[initial_tool] == "PEI"}8{elsif filament_type[initial_tool] == "PET" or filament_type[initial_tool] == "PETG"}14{elsif filament_type[initial_tool] == "PP"}16{else}0{endif} W{if filament_type[initial_tool] == "PET" or filament_type[initial_tool] == "PETG" or filament_type[initial_tool] == "CPE" or filament_type[initial_tool] == "PP" or filament_type[initial_tool] == "NGEN"}1{elsif filament_type[initial_tool] == "PEI"}2{elsif filament_type[initial_tool] == "ASA" or filament_type[initial_tool] == "ABS" or filament_type[initial_tool] == "PC"}3{elsif filament_type[initial_tool] == "FLEX"}5{elsif filament_type[initial_tool] == "PA"}6{else}0{endif}; steel sheet check

and before

M115 U3.14.1 ; tell printer latest fw version

This will add automatically during slicing the needed M862.7 P<value> W<value> to the start gcode.
I tried to add the M862.7 to the PrusaSlicer Filament section, but frankly Custom G-Codes are added after the Printer tab Start G-Code. These kind of checks need to be at the beginning, like the Printer Type Nozzle size checks already are!
In LCD Settings -> HW Setup -> Checks -> Sheet default is
- [Warn] which will warn the user on LCD screen with a timeout message when
  - the expected/supported sheet isn't selected / placed on the printer
  - the selected sheet has some warnings, like use glue stick
In LCD Settings -> HW Setup -> Steel Sheets -> you find a new menu Type
- [Smooth | Texture | Satin | NylonPA | PolyPro | Custom]
Ideally you have at lest two Steel sheets calibrated.

Test 1

Connect with a serial terminal
a. ideally enable some logging
Select LCD Settings -> HW Setup -> Checks -> Sheet [Warn]
Select Smooth sheet
Send M862.7 P7 W0 to simulate a PLA print, which can be printed on Smooth, Textured and Satin sheets BUT NOT on NylonPA or PP sheets.
a. Nothing shown on LCD screen
Send M862.7 P14 W1 to simulate a PET/G print, which can be printed on Textured, Satin and NylonPA sheets BUT NOT on PP sheets. With a glue stick applied the usage of the Smooth sheet is possible and will warn the user.
a. LCD should show for ~30 seconds

Check selected steel
sheet.

>Cont.        Cancel

Select LCD Settings -> HW Setup -> Checks -> Sheet [Strict]
Repeat Steps 3 to 5
a. The LCD screen of step 5 shows and NEEDS to be confirmed on LCD

Check selected steel
sheet.

                   v

Select LCD Settings -> HW Setup -> Checks -> Sheet [Always]
Repeat Steps 3 to 5
a. The LCD message is always shown, but it times out and will continue

Test 2

Connect with a serial terminal
a. ideally enable some logging
Select LCD Settings -> HW Setup -> Checks -> Sheet [Warn]
Select Smooth sheet
Slice a simple short PLA print with the new/modified PrusaSlicer profile
Start this PLA print
As the Smooth sheet is compatible with PLA no warnings are shown.
Slice a simple short PETG print with the new/modified PrusaSlicer profile
As the Smooth sheet should be used with glue stick while printing PET/G
a. LCD should show for ~30 seconds

Check selected steel
sheet.

>Cont.        Cancel

Select LCD Settings -> HW Setup -> Checks -> Sheet [Strict]
Repeat step 3 to 8 and you should get same results as in Test 1
Select LCD Settings -> HW Setup -> Checks -> Sheet [Always]
Repeat step 3 to 8 and you should get same results as in Test 1 with one addition
b. To also check "old" gcode without M862.7, the check is also executed when M115 is send during a print and shows following screen which DOESN'T timeout and NEEDS user interaction!

Check selected steel
sheet.

 Cont.       >Cancel

i. To not delay host connections the M115 doesn't execute the check when the printer is inactive.
ii. Frankly at this moment new gcode will show the LCD message twice when Always is selected.

Fix rebase issues

github-actions · 2025-01-08T15:06:34Z

All values in bytes. Δ Delta to base

Target	ΔFlash	ΔSRAM	Used Flash	Used SRAM	Free Flash	Free SRAM
`MK3S_MULTILANG`	662	2	248330	5656	5622	2536
`MK3_MULTILANG`	734	2	247772	5665	6180	2527

ingbrzy · 2025-01-08T15:08:04Z

lang/po/Firmware_sk.po

+#: ../../Firmware/Marlin_main.cpp:5844 ../../Firmware/messages.cpp:163
+#: ../../Firmware/util.cpp:454 ../../Firmware/util.cpp:455
+msgid "Check selected steel sheet."
+msgstr "Skontrolujte vybraný platňa."


should be "Skontrolujte vybranú platňu"

Thanks, will wait for other reviews and commit later

Hauzman · 2025-01-08T15:13:28Z

@3d-gussner RO looks good from my perspective

stelgenhof · 2025-01-08T15:33:53Z

@3d-gussner NL looks good to me

Ilovemyhous · 2025-01-08T16:07:01Z

French gets a green light from my side. 👍

AttilaSVK · 2025-01-08T18:17:43Z

Hungarian should be "Ellenőrizd a kiválasztott az tárgyasztal lapot"

3d-gussner · 2025-01-09T05:23:41Z

Hungarian should be "Ellenőrizd a kiválasztott az tárgyasztal lapot"

Thanks for the suggestion. I searched for existing terms and words and for steel sheet I found these:

"Please place steel sheet on heatbed."
"Kerlek, helyzed az acellapot a targyasztalra."

"Please remove steel sheet from heatbed."
"Kerlek, tavolisd el az acellapot az asztalrol."

Can you please also review the rest of the translations (of course so they do not exceed the limits) for "check"?

Now I see "Ellenorizd" and "Nezd meg a" (look at ???) are used for "Check"

Also you can use the diacritics. In this case "Ellenorizd" should be "Ellenőrizd" or not?

leptun · 2025-01-09T07:51:55Z

@3d-gussner For ro I would do Verificați suprafața de print selectată. for consistency with the steel sheet naming in the other translations. Still 2 rows so it fits

3d-gussner · 2025-01-09T08:51:56Z

@3d-gussner For ro I would do Verificați suprafața de print selectată. for consistency with the steel sheet naming in the other translations. Still 2 rows so it fits

Thanks

I will wait for potential other changes before committing.

ErwanAliasr1 · 2025-01-09T18:25:30Z

Totally agree, thx ! Le mer. 8 janv. 2025 à 17:07, Ilovemyhouse ***@***.***> a écrit :

…

French gets a green light from my side. 👍 — Reply to this email directly, view it on GitHub <#4832 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCUIHLKSLSE3EYHEMDQ7P32JVEL3AVCNFSM6AAAAABU2EFJVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYGA2TGNZZGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

AttilaSVK · 2025-01-10T06:37:58Z

Hungarian should be "Ellenőrizd a kiválasztott az tárgyasztal lapot"

Thanks for the suggestion. I searched for existing terms and words and for steel sheet I found these:

"Please place steel sheet on heatbed." "Kerlek, helyzed az acellapot a targyasztalra."

"Please remove steel sheet from heatbed." "Kerlek, tavolisd el az acellapot az asztalrol."

Can you please also review the rest of the translations (of course so they do not exceed the limits) for "check"?

Now I see "Ellenorizd" and "Nezd meg a" (look at ???) are used for "Check"

Also you can use the diacritics. In this case "Ellenorizd" should be "Ellenőrizd" or not?

"Kérlek, helyzed a lapot a tárgyasztalra." - the literal translation is please place sheet on the object table. In Hungarian we don't really say that it's from steel. (kind of like in the Czech original, if I recall correctly)

However, just for consistency sake:
"Kérlek, távolítsd el a lapot a tárgyasztalról." - plase remove the sheet from the object table

Yes, Nézd meg literally means Look at, but it can mean Check as well. I might have used it instead of Ellenőrizd to save two characters. I'm thinking of going through the entire Hungarian translation in the near future to make it more consistent (and to add diacritics)

As for the diacritics, Ellenőrizd is correct.

leptun · 2025-01-10T07:17:17Z

I'm thinking of going through the entire Hungarian translation in the near future to make it more consistent (and to add diacritics)

Please tag me when you start working on that as we may have to make a few changes to the diacritics scripts (enable/disable individual characters from the font based on usage).

Add Sheet warning bit check Improve `M115` steel check when `Always` is selected for host connection Add some debug output

3d-gussner · 2025-01-10T08:26:32Z

@AttilaSVK Thanks for the response. Please also tag @leptun when you are done, so we can try to get all used Hungarian diacritics shown correctly.

after boot.

3d-gussner added 2 commits January 8, 2025 14:05

Sheet types init

fe8f77d

Fix rebase issues

Update messsage and translations

c065e48

ingbrzy reviewed Jan 8, 2025

View reviewed changes

3d-gussner added the Post release tasks open Tasks after release label Jan 10, 2025

Add Sheet bit check

a66d5bb

Add Sheet warning bit check Improve `M115` steel check when `Always` is selected for host connection Add some debug output

Fix EEPROM_CHECK_SHEET_TYPE reset to Warn

5e60a15

after boot.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚧 WIP: Steel sheet check #4832

🚧 WIP: Steel sheet check #4832

3d-gussner commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

ingbrzy Jan 8, 2025 •

edited

Loading

3d-gussner Jan 8, 2025

Hauzman commented Jan 8, 2025

stelgenhof commented Jan 8, 2025

Ilovemyhous commented Jan 8, 2025

AttilaSVK commented Jan 8, 2025

3d-gussner commented Jan 9, 2025 •

edited

Loading

leptun commented Jan 9, 2025

3d-gussner commented Jan 9, 2025 •

edited

Loading

ErwanAliasr1 commented Jan 9, 2025 via email

AttilaSVK commented Jan 10, 2025

leptun commented Jan 10, 2025

3d-gussner commented Jan 10, 2025

🚧 WIP: Steel sheet check #4832

Are you sure you want to change the base?

🚧 WIP: Steel sheet check #4832

Conversation

3d-gussner commented Jan 8, 2025 • edited Loading

github-actions bot commented Jan 8, 2025 • edited Loading

ingbrzy Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

3d-gussner Jan 8, 2025

Choose a reason for hiding this comment

Hauzman commented Jan 8, 2025

stelgenhof commented Jan 8, 2025

Ilovemyhous commented Jan 8, 2025

AttilaSVK commented Jan 8, 2025

3d-gussner commented Jan 9, 2025 • edited Loading

leptun commented Jan 9, 2025

3d-gussner commented Jan 9, 2025 • edited Loading

ErwanAliasr1 commented Jan 9, 2025 via email

AttilaSVK commented Jan 10, 2025

leptun commented Jan 10, 2025

3d-gussner commented Jan 10, 2025

3d-gussner commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025 •

edited

Loading

ingbrzy Jan 8, 2025 •

edited

Loading

3d-gussner commented Jan 9, 2025 •

edited

Loading

3d-gussner commented Jan 9, 2025 •

edited

Loading