Skip to content

Commit

Permalink
Revert "[ML] Return both modelId and inferenceId (elastic#111490)"
Browse files Browse the repository at this point in the history
Both `model_id` and `inference_id` were returned from the inference API
to support backwards compatibility while kibana migrates to
`inference_id`.

Now that the migration is complete, we will stop returning `model_id`.

This reverts commit 3b8970c.
  • Loading branch information
prwhelan committed Sep 4, 2024
1 parent 2982fc6 commit 909fb7e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions docs/changelog/111490.yaml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
if (params.paramAsBoolean(USE_ID_FOR_INDEX, false)) {
builder.field(INDEX_ONLY_ID_FIELD_NAME, inferenceEntityId);
} else {
builder.field(INDEX_ONLY_ID_FIELD_NAME, inferenceEntityId);
builder.field(INFERENCE_ID_FIELD_NAME, inferenceEntityId);
}
builder.field(TaskType.NAME, taskType.toString());
Expand All @@ -143,7 +142,6 @@ public XContentBuilder toFilteredXContent(XContentBuilder builder, Params params
if (params.paramAsBoolean(USE_ID_FOR_INDEX, false)) {
builder.field(INDEX_ONLY_ID_FIELD_NAME, inferenceEntityId);
} else {
builder.field(INDEX_ONLY_ID_FIELD_NAME, inferenceEntityId);
builder.field(INFERENCE_ID_FIELD_NAME, inferenceEntityId);
}
builder.field(TaskType.NAME, taskType.toString());
Expand Down

0 comments on commit 909fb7e

Please sign in to comment.