Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 2025 stable style #4558

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

JelleZijlstra
Copy link
Collaborator

Closes #4522

@JelleZijlstra
Copy link
Collaborator Author

Looks like unify_docstring_detection does bad things to our ipynb support...

@JelleZijlstra
Copy link
Collaborator Author

CI is failing because the stable style changed: https://github.com/psf/black/actions/runs/12943341153/job/36102520632?pr=4558 . The changes are as expected, mostly around docstrings and trailing commas for typed parameters. I'll land this but hold off on releasing to see if we can get the PEP 695 fix in too.

token = token[:-1]
# We use a bytestring so that the string does not get interpreted
# as a docstring.
return f'b"{token}"'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting the 2025 stable style
2 participants