Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade OpenAL Soft version to fix compatibility #193

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

illteteka
Copy link
Contributor

This is an older port of OpenAL Soft from around 2009. The version of OpenAL in this repo (1.23.1) does not compile for the PSP. If anyone else wants to test this, I have an example program to test it with: https://github.com/illteteka/openal-soft-psp/tree/main/examples/pitch

@sharkwouter
Copy link
Member

Thanks for this PR! I tested it and the example works great. The package also looks good. The one thing I am missing is a pkgconfig file. Would it be possible to add this still?

@illteteka
Copy link
Contributor Author

Ok! I added it back

@sharkwouter
Copy link
Member

It seems you're still missing some data in it:

Name: OpenAL
Description: OpenAL is a cross-platform 3D audio API
Requires: @PKG_CONFIG_REQUIRES@
Version: @PACKAGE_VERSION@
Libs: -L${libdir} -l@LIBNAME@ @PKG_CONFIG_LIBS@
Cflags: -I${includedir}

In the upstream version that looks like this:

Name: OpenAL
Description: OpenAL is a cross-platform 3D audio API
Requires: 
Version: 1.23.1
Libs: -L${libdir} -lopenal 
Libs.private: -latomic -lm
Cflags: -I${includedir} -I${includedir}/AL -DAL_LIBTYPE_STATIC

Not sure if that is correct, but it should give you some idea.

@illteteka
Copy link
Contributor Author

Ok I'll look into this

@illteteka
Copy link
Contributor Author

Ok this and the library have been updated. We shouldn't need all the stuff in the latest pkgconfig. AL_LIBTYPE_STATIC was added in a newer version, for example

@sharkwouter sharkwouter merged commit 755a1a6 into pspdev:master Dec 13, 2024
82 checks passed
@sharkwouter
Copy link
Member

Thanks! It looks good now

@technicaljicama
Copy link

Is there any chance later openal versions such as 1.21.1 will make it's way back? I have tried to compile them, without success so far (related to pthreads). Newer openal adds effects (AL/efx.h) for example.

@illteteka
Copy link
Contributor Author

@technicaljicama The issue you're referring to is why this regression happened in the first place. This was the only version of OpenAL Soft I could find that compiled (and worked) on the PSP. If someone else is willing to do a newer port then I'm willing to deprecate this version.

@sharkwouter
Copy link
Member

@technicaljicama you could try using MojoAL and see if that has the functions you need. That uses SDL2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants