Work around false cpychecker false positive

davidmalcolm/gcc-python-plugin#158
psycopg · Jan 22, 2019 · 6acd4d8 · 6acd4d8
1 parent 80c4f51
commit 6acd4d8
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/psycopg/connection_type.c b/psycopg/connection_type.c
@@ -474,6 +474,16 @@ _psyco_conn_parse_isolevel(PyObject *pyval)
         }
 
         rv = level;
+
+        /* Redundant test, checked above.
+         * Work around a cpychecker false positive.
+         * davidmalcolm/gcc-python-plugin#158
+         */
+        if (rv < 0) {
+            PyErr_SetString(PyExc_ValueError,
+                "isolation_level must be between 1 and 4");
+            goto exit;
+        }
     }
 
     /* parse from the string -- this includes "default" */