Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding property to return insights-client version #16

Merged

Conversation

Archana-PandeyM
Copy link

No description provided.

Copy link
Owner

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally OK, there a couple of things to fix

also, please sign-off your commits at the end of each commit message:

Signed-off-by: ...

see the -s/--signoff parameter to git commit

pytest_client_tools/insights_client.py Outdated Show resolved Hide resolved
pytest_client_tools/insights_client.py Outdated Show resolved Hide resolved
@Archana-PandeyM Archana-PandeyM force-pushed the arpandey/addClientVersionProperty branch from db47757 to e87550b Compare August 5, 2024 09:38
Copy link
Owner

@ptoscano ptoscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@ptoscano ptoscano merged commit 4b977b4 into ptoscano:main Aug 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants