-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gnuradio 3.10 - 3.11 support #600
base: master
Are you sure you want to change the base?
Conversation
Update to last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bkerler,
Welcome to gr-gsm
and thanks for taking the time to port it to the latest gnuradio version. Your effort would be much appreciated.
Tested with gnuradio 3.11.
Have you tested it with 3.10 as you branch is called maint-3.10
and not maint-3.11
. Are you familiar with docker
and can you provide some Dockerfiles similar to tests/dockerfiles/Ubuntu_20_04.docker
and tests/dockerfiles/Debian_testing.docker
. Previously we have used TravisCI for testing but right now there is something wrong with it but sill we can use these the Dockerfiles for local testing.
I still haven't finished the whole review as there are quite a lot of changes but here are some comments
Hi, thanks for pointing them out, I've resolved the issues as you proposed. |
I've tested the module with 3.10 and 3.11. It should work with 3.9 as well. |
Regarding docker : I'm not a big fan of it. But I will be able to provide a local installation script/package soon (which doesn't interfer with the installed system). |
Sorry to ask this question, I'm aware that on open source there is strictly no ETA, but when is this roughly expected to land in master, in a week or two perhaps ? |
Seems the code is incompatible with 3.9 as gnuradio added incompatible cmake options on 3.10. |
For those interested into support for 3.9, I did a backport here: https://github.com/bkerler/gr-gsm/tree/maint-3.9 |
First of all, thanks for your effort! I tried to migrate to 3.9 myself, but quickly gave up. This Pull Request mixes up several things. The topic is "Add gnuradio 3.10 - 3.11 support", however you're also adding a new block (Multi Arfcns GSM Receiver) here. Ideally this should be done in a separate Pull Request. Also, small commits like dc7774c, 5accd4a, 14c94dc, and d667096 should be squashed into the main commit because IMO it makes a little sense to have them in the git log. |
Yes, I've added other existing pull requests where it seemed reasonable to integrate them. It wasn't planned to write a pr in the beginning, that's why I didn't keep it separately, sorry. I could separate it from the port but that might take a while if that's really required. |
The "path" issue is required to match the gnuradio 3.9 project structure and to avoid conflicts with existing non-gnuradio python packets. Backporting to <3.9 doesn't make sense to me to be honest. |
I've removed the multi arfcns stuff. |
Remove gsm import
IT did not work or I miss some dependency ? I install fnuradio 3.10 and install grgsm from @bkerler source
BTW I can't run "grgsm_livemon" it show me " command not found " |
@bkerler the person above mentioned a grgsm_decode issue, which if I recall is the same issue I had. @pixkike find the flow graph in that source you pulled down, open it in gnuradio and generate the Python file. Make it executable, remove the .py and put it in bin. That’s from memory but I think it’s about what I did. |
Yes that's how it works right now, but that's not the way it's intended to work |
here's the error :
|
it's basically commit 6eea94f that fails. |
Thanks. I've fixed this and opened a PR in your fork bkerler#3. Now I'm trying to fix the failure in |
Fix building of grgsm_livemon and grgsm_livemon_headless
Patch 1020-reproducible-build.patch from Debian package, written by Chris Lamb to solve https://bugs.debian.org/891405 .
Make the build reproducible
Hi, I am still experiencing issues on livemon compilation (I am using Kali 2022) and maint-3.10-fixes and Gnun 3.10.4
Block paths:
4 errors from flowgraph: Compilation error |
Hey @alphafox02 so if I comment out the code as per above, how do I manually generate the two items post build (as a works around for the issue). Best regards |
I’m pretty certain @bkerler fork maint_3.10 branch has all this sorted out now and the files are generated after the make install. Not at my computer at the moment but will check this evening. |
Fixed with latest commits on both multiarfcn and main-3.10 branches. |
Hi, So I am using rasberry Pi Python 3.10.5 With
It still wont compile livemon. I can make if work, commenting out the CMakeLists thing The error I get is the same as per above
Block paths:
4 errors from flowgraph: Compilation error (not sure of relevant) If I do a simple import of the gnuradio files I get this
Please help |
@alphafox02 Did you manage to test this to see if it's working for you now? As per above I commented it out and managed to get to a make install, thinking once the files were in place it might all work for the grc's but it still giving me pain. How do you manually generate grgsm_livemon and grgsm_livemon_headless ? |
If I recall, I’ve not had to do anything manual nowadays. I’ve built the non multi arfcn branch on x86_64 and aarch64 now. If you look up DragonOS Pi64 you’ll find the image prebuilt with 3.10.4 + grgsm etc. maybe take a peak and see what’s different about it. |
To Manually generate you can open the flow graphs with gnuradio companion, click the button to generate the py file. Remove the .py extension, make then executable with chmod, and place then I think in /usr/local/bin, but you should’nt have to do that anymore. |
Ok great thanks for the info. will definitely look into both of those things |
@dstuart @bkerler fyi - I tried to build the multi arfcn branch for 3.10 and experienced this as well #600 (comment) w/ GR 3.10.4/22.04 It does not occur when using the non multi arfcn branch w/ GR 3.10. |
Fixed by updating symlink |
Tras compilar y tratar de importar el modulo gsm, aparece el siguiente fallo
en el /usr/local/lib/python3.11/dist-packages/gnuradio/gsm/__init__.py esta sección
Por algun motivo no encuentra la siguiente libreria al compilar
Esta otra libreria parece que no esta enlazada con aquella.
Esta clase lib/demapping/universal_ctrl_chans_demapper_impl.cc por lo visto tampoco es encontrada al ejecutar su envoltorio desde python..
|
Tested with gnuradio 3.11. Adds additional patches from other pull requests.
I had to restructure the directories in order to match the official gnuradio module structure.