-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test with graphql and sqlite storage #6782
base: master
Are you sure you want to change the base?
Add test with graphql and sqlite storage #6782
Conversation
the _attachments is leaked in the graphql payload
}); | ||
}; | ||
|
||
const dbName = randomCouchString(10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randomCouchString
is called randomToken
in RxDB v16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this branch based on RxDB 15.39, because we are not ready to switch to RxDB 16 yet (we will switch to the version 16 eventually). Would it be possible to fix this issue in RxDB 15.39?
randomToken is not available in RxDB 15.39
Hi @mapineaultvooban |
* OnPage SEO * ADD stuff * ADD meta data * FIX sidebar titles * ADD internal links
* OnPage SEO * ADD stuff * ADD meta data * FIX sidebar titles * ADD internal links * ADD landingpage indexeddb v2
the _attachments is leaked in the graphql payload
…tachment' into graphql_replication_attachment
This reverts commit fbaea6c.
I am sorry but this PR has 528 changed files and is unreadable. Please rebase or recreate. Also please never commit files from the |
the _attachments is leaked in the graphql payload
This PR contains:
A unit test that executes a migration on a database with a sqlite storage. Then a graphql server sends an update with leaked property (assumedMasterState contains the _attachments property). I wrote some comments in the test, because I don't have access to the premium package (RxStorageSQLite) in this repository.
When we use a different storage (e.g in memory or another default storage in the public package), the test passed.
Describe the problem you have without this PR
In our project, we use a RxDatabase with
In one of our schemas, we add a new migration. when executed, it seems that the _attachments property is followed. When a user updates a property in an entity, the graphQL server push the update to our backend, causing an error in the serialization (input -> classes).
Here is a payload of one of our shemas with the problem. In the entity's masterState, we can see that the _attachments property is leaked.
Here is our database setup
Todos