Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty stream http status code #261

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

amirRamirfatahi
Copy link
Collaborator

@amirRamirfatahi amirRamirfatahi commented Dec 20, 2024

Fixes #254

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

Copy link
Collaborator

@SHAcollision SHAcollision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ready to merge. @amirRamirfatahi remember to "squash and merge"

@amirRamirfatahi amirRamirfatahi merged commit 0f0ad25 into main Jan 13, 2025
3 checks passed
@SHAcollision SHAcollision deleted the fix/streams-http-codes branch February 12, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat (service): use status code 204 instead of 404 for /stream/posts and /stream/users
2 participants