Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: derive Default trait #274

Merged
merged 2 commits into from
Jan 2, 2025
Merged

chore: derive Default trait #274

merged 2 commits into from
Jan 2, 2025

Conversation

tipogi
Copy link
Collaborator

@tipogi tipogi commented Jan 2, 2025

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@tipogi tipogi requested a review from SHAcollision January 2, 2025 09:07
@tipogi tipogi self-assigned this Jan 2, 2025
SHAcollision
SHAcollision approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@SHAcollision SHAcollision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 Only format needs fixing.

@tipogi tipogi merged commit 31fe413 into main Jan 2, 2025
2 of 3 checks passed
@tipogi tipogi deleted the chore/default-impl branch January 2, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SHAcollision SHAcollision SHAcollision approved these changes

Assignees

@tipogi tipogi

Labels
chores 🔮 nexus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tipogi @SHAcollision