Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hot tags tests failing based on time of the month #275

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

amirRamirfatahi
Copy link
Collaborator

Fixes #273

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@tipogi
Copy link
Collaborator

tipogi commented Jan 4, 2025

In hot-tags.cypher, the day and month params are unused. Looks good that implementation 🚀

Copy link
Collaborator

@SHAcollision SHAcollision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just remove the unused code @tipogi pointed out and ready to merge.

@amirRamirfatahi amirRamirfatahi merged commit de24c37 into main Jan 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: hot tags by timeframe tests are time sensitive
3 participants