Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: bump pubky v0.4, pkarr v3, mainline v5 #277

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Chore: bump pubky v0.4, pkarr v3, mainline v5 #277

merged 6 commits into from
Jan 17, 2025

Conversation

SHAcollision
Copy link
Collaborator

@SHAcollision SHAcollision commented Jan 6, 2025 •
edited
Loading

Updated all pubky deps to the latest release candidates. Fixed all breaking Pubky core APIs.

TODO:

  • 1. Use the new client to request /events to homeserver.
  • 2. Figure mainline::Testnet::new(10) bug

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@SHAcollision SHAcollision added enhancement New feature or request dependencies Pull requests that update a dependency file 🔮 nexus 👀 watcher chores labels Jan 6, 2025
@SHAcollision SHAcollision force-pushed the bump/pubky branch 2 times, most recently from c31bbcd to b655aa6 Compare January 6, 2025 20:33
@SHAcollision SHAcollision requested review from tipogi and amirRamirfatahi and removed request for tipogi January 6, 2025 23:06
SHAcollision
SHAcollision commented Jan 6, 2025
View reviewed changes
Cargo.toml Outdated
base32 = "0.5.1"
blake3 = "1.5.5"
url = "2.5.4"
async-trait = "0.1.84"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Axum 0.8.1 does not re-export async_trait anymore

tipogi
tipogi reviewed Jan 7, 2025
View reviewed changes
src/events/processor.rs

pub struct EventProcessor {
http_client: Client,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

amirRamirfatahi
amirRamirfatahi approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@amirRamirfatahi amirRamirfatahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, apart from being against using specific "branches" or "revisions" when it comes to deps, rather than just using their latest cargo version, as it's just creating some eventual headache while not providing much right now, it looks good!

src/lib.rs Outdated
@@ -20,5 +20,4 @@ pub use events::processor::EventProcessor;
pub use reindex::reindex;
pub use setup::setup;

#[macro_use]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm why is this not needed anymore?

src/routes/macros.rs Outdated
@@ -5,12 +5,3 @@ macro_rules! register_routes {
$(.route($path, axum::routing::get($handler)))*
};
}

/// Transforms a "swagger-like" endpoint to "axum-like" manipulating &'static str
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did utopia start supporting axum-like routes?

Copy link
Collaborator Author

@SHAcollision SHAcollision Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Well, the other way around, Axum started supporting Utoipa-like endpoints.

@SHAcollision
Copy link
Collaborator Author

IMO, apart from being against using specific "branches" or "revisions" when it comes to deps,

Agree. This is needed for deps with fixes that are yet unreleased. We will use the standard tag by crates.io version once these release.

while not providing much right now,

There is no other way to make this work 🤔 First commit in this PR is coming from unmerged #276, maybe this is creating some confusion.

@SHAcollision
Copy link
Collaborator Author

There is still some issues when using the watcher binary with a standalone homeserver over testnet. Will wait for a fix on pubky v0.4 before we merge here.

@SHAcollision SHAcollision merged commit 9396b49 into main Jan 17, 2025
3 checks passed
@SHAcollision SHAcollision deleted the bump/pubky branch February 12, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipogi tipogi tipogi left review comments

@amirRamirfatahi amirRamirfatahi amirRamirfatahi approved these changes

Assignees
No one assigned
Labels
chores dependencies Pull requests that update a dependency file enhancement New feature or request 🔮 nexus 👀 watcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SHAcollision @amirRamirfatahi @tipogi