Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skip pagination over post tags #293

Merged
merged 4 commits into from
Jan 20, 2025
Merged

feat: add skip pagination over post tags #293

merged 4 commits into from
Jan 20, 2025

Conversation

tipogi
Copy link
Collaborator

@tipogi tipogi commented Jan 16, 2025

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

  • Testing: Implement and pass new tests for the new features/fixes, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@tipogi tipogi linked an issue Jan 16, 2025 that may be closed by this pull request
Feat(service): add skip pagination over post tags #291
Closed
@tipogi tipogi requested a review from SHAcollision January 17, 2025 06:23
@tipogi tipogi marked this pull request as ready for review January 17, 2025 06:29
@tipogi tipogi self-assigned this Jan 17, 2025
SHAcollision
SHAcollision approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@SHAcollision SHAcollision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@tipogi tipogi merged commit 9a53bc3 into main Jan 20, 2025
3 checks passed
@tipogi tipogi deleted the feat/tag-limit-param branch January 20, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SHAcollision SHAcollision SHAcollision approved these changes

Assignees

@tipogi tipogi

Labels
enhancement New feature or request 🔮 nexus 🌐 service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(service): add skip pagination over post tags
2 participants
@tipogi @SHAcollision