Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable cors #82

Merged
merged 3 commits into from
Aug 21, 2024
Merged

feat: enable cors #82

merged 3 commits into from
Aug 21, 2024

Conversation

MiguelMedeiros
Copy link
Member

@MiguelMedeiros MiguelMedeiros commented Aug 20, 2024

Pre-submission Checklist

For tests to work you need a working neo4j instance with the example dataset in docker/db-migration

  • Testing: Implement and pass new tests for all new code, while maintaining existing test suite, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@MiguelMedeiros MiguelMedeiros added the enhancement New feature or request label Aug 20, 2024
@MiguelMedeiros MiguelMedeiros added this to the v0.0.X - Alpha milestone Aug 20, 2024
@MiguelMedeiros MiguelMedeiros self-assigned this Aug 20, 2024
@SHAcollision
Copy link
Collaborator

I added one more commit, if that still works on your end, looks good to merge to me! However if you can try removing:

        .allow_origin(Any) // Allow all origins
        .allow_methods(Any) // Allow all HTTP methods
        .allow_headers(Any); // Allow all headers

And that still works... then, let's remove those lines and the import of Any as well before merging 🚀

@MiguelMedeiros
Copy link
Member Author

ACK tested! ✅
Good to go! 🚀

@SHAcollision SHAcollision merged commit 23c131b into main Aug 21, 2024
3 checks passed
@SHAcollision SHAcollision deleted the feat/add-cors branch August 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🔮 nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants