Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error handling in stream posts handlers #84

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

MiguelMedeiros
Copy link
Member

When I received a stream of posts that exceeded the limit, I encountered a 500 Internal Server Error.
I have now updated it to a more appropriate error message, a 404 Not Found error.

Pre-submission Checklist

For tests to work you need a working neo4j instance with the example dataset in docker/db-migration

  • Testing: Implement and pass new tests for all new code, while maintaining existing test suite, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@MiguelMedeiros MiguelMedeiros added the bug Something isn't working label Aug 21, 2024
@MiguelMedeiros MiguelMedeiros added this to the v0.0.X - Alpha milestone Aug 21, 2024
@MiguelMedeiros MiguelMedeiros self-assigned this Aug 21, 2024
Copy link
Collaborator

@SHAcollision SHAcollision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🚀 Not sure why we were using InternalServerError for a empty list of posts. Looks like a typo/bug. LGTM!

@MiguelMedeiros MiguelMedeiros merged commit 6b2ab8b into main Aug 23, 2024
3 checks passed
@MiguelMedeiros MiguelMedeiros deleted the fix/error-handling-streams-posts branch August 23, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔮 nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants