Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PubkyApp schemas #90

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Add PubkyApp schemas #90

merged 5 commits into from
Aug 28, 2024

Conversation

SHAcollision
Copy link
Collaborator

Pre-submission Checklist

For tests to work you need a working neo4j instance with the example dataset in docker/db-migration

  • Testing: Implement and pass new tests for all new code, while maintaining existing test suite, cargo test.
  • Performance: Ensure new code has relevant performance benchmarks, cargo bench

@SHAcollision SHAcollision added enhancement New feature or request 🔮 nexus labels Aug 27, 2024
@SHAcollision SHAcollision requested a review from tipogi August 27, 2024 08:00
@SHAcollision SHAcollision self-assigned this Aug 27, 2024
@Nuhvi
Copy link

Nuhvi commented Aug 27, 2024

I think calling these "homeserver" schemas is confusing

@SHAcollision SHAcollision force-pushed the feat/homeserver-schemas branch from 408b32f to 6ea52a2 Compare August 27, 2024 09:45
@SHAcollision SHAcollision force-pushed the feat/homeserver-schemas branch from 6ea52a2 to 4df9e38 Compare August 27, 2024 13:03
@SHAcollision
Copy link
Collaborator Author

SHAcollision commented Aug 27, 2024

I think calling these "homeserver" schemas is confusing

What do you propose? From the point of view of Nexus this is how we deserialize the data we get from homeservers.

@Nuhvi
Copy link

Nuhvi commented Aug 28, 2024

@SHAcollision I suggest calling it PubkyDotApp or PubkyApp schemas... since that is what they are and where they are defined.

@SHAcollision SHAcollision force-pushed the feat/homeserver-schemas branch from 6d89a9e to 199f250 Compare August 28, 2024 09:19
@SHAcollision
Copy link
Collaborator Author

PubkyApp

Makes sense, I renamed them all as PubkyApp models.

@SHAcollision SHAcollision changed the title Add homeserver schemas Add PubkyApp schemas Aug 28, 2024
@SHAcollision SHAcollision merged commit 2a1be05 into main Aug 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🔮 nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants