Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused Activity model generator #341

Merged

Conversation

ur5us
Copy link
Collaborator

@ur5us ur5us commented Oct 3, 2019

FIXES #338

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

Thanks, Juri!

@ur5us
Copy link
Collaborator Author

ur5us commented Oct 3, 2019

@pokonski This is going against #154 long term (which I like a lot actually) but removes some confusion short term.

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

Yep, good point. I'll see ask @jnraine if he is still interested in rebasing that PR on top of this change :)

@ur5us
Copy link
Collaborator Author

ur5us commented Oct 3, 2019

@pokonski Even if @jnraine is not interested, I am and could do that if you’re open to the proposed feature in general.

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

Yep, definitely! That feature would be great to have ❤️

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

Hmm, weird failure in CI, specs pass but rake task returns failure

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

Ah I see, specs need adjustments, too:

File does not exist: generators/public_activity/activity/activity_generator

@ur5us can you also fix this?

@ur5us
Copy link
Collaborator Author

ur5us commented Oct 3, 2019

@pokonski Will do! I’m having trouble running the tests locally so had to push for CI.

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

No worries, they do require a lot of setup and various DB servers running

@ur5us ur5us force-pushed the cleanup-unused-activity-model branch from bfeea85 to 6c41068 Compare October 3, 2019 10:24
@pokonski pokonski merged commit 1cbe897 into public-activity:1-6-stable Oct 3, 2019
@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

And merged, thanks a lot for this 😁

@davegson
Copy link

davegson commented Oct 3, 2019

this totally fell out of my radar, sorry @pokonski for not following up on my word. Even more then: thank you @ur5us!! 🎉

@pokonski
Copy link
Member

pokonski commented Oct 3, 2019

@davegson if there's anyone with a broken radar, it's me 😁

@davegson
Copy link

davegson commented Oct 3, 2019

😅👍

@ur5us
Copy link
Collaborator Author

ur5us commented Oct 3, 2019

@pokonski Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further extend PublicActivity::Activity model
3 participants