Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow no-cost manual renewal #263

Merged
merged 4 commits into from
Oct 1, 2024
Merged

allow no-cost manual renewal #263

merged 4 commits into from
Oct 1, 2024

Conversation

jason-c-child
Copy link
Contributor

This change should allow a no-cost manual renewal of a name without a valid bid to address issues found by @jhernandezb when testing in beta.

Note: includes commit to bump patch version

@jason-c-child
Copy link
Contributor Author

NOTE: looks like tests are failing due to a CI auth issue....

Build-agent version 1.0.251946-b2a3f35d (2024-09-27T19:51:38+0000).
System information:
 Server Version: 24.0.9
 Storage Driver: overlay2
  Backing Filesystem: xfs
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Kernel Version: 5.15.0-1057-aws
 Operating System: Ubuntu 20.04.6 LTS
 OSType: linux
 Architecture: x86_64

Starting container rust:1.72.1
Warning: No authentication provided, using CircleCI credentials for pulls from Docker Hub.
  image cache not found on this host, downloading rust:1.72.1

Error response from daemon: Head "https://registry-1.docker.io/v2/library/rust/manifests/1.72.1": unauthorized: incorrect username or password

@jason-c-child jason-c-child marked this pull request as ready for review September 30, 2024 14:29
@jhernandezb jhernandezb merged commit 179edd1 into main Oct 1, 2024
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants