Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnableExif #421

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

EnableExif #421

wants to merge 10 commits into from

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Sep 3, 2019

Fixes #169 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

=========

changes:

  • fullResolutionSrc option is now used to check for EXIF metadata if provided, instead of automatically img.getElement(), because img.getElement() may typically be a compressed version with no metadata on it.
  • EnableExif should now be working, but need to test with an image with gps data (neither example.jpg or large.jpg have GPS data. - example.jpg has no EXIF metadata at all and large.jpg has some but not GPS)

pending:

  • bump version
  • test with image with gps data
  • update docs
    • note somewhere that metadata will only work with jpg's and tiff's
    • update fullResolutionSrc option docs
  • refactor
  • I think remove orientation check because we have our own logic to figure out the rotation angle, and implement that logic instead
  • fix usage of overlay._corners to overlay.setCorners()

=========

@sashadev-sky
Copy link
Member Author

@jywarren @rexagod how do I find an image with gps data to test this?

@sashadev-sky
Copy link
Member Author

@jywarren just wanted to follow up here!! Because I think I fixed the functionality and we've been needing to do that for a while. but don't know where to get an image with location data?

@jywarren
Copy link
Member

Aha! Good question. Here's some! https://publiclab.org/notes/patcoyle/03-23-2015/using-the-mapknitter-2-image-placement-using-geotagged-images

You can download them and use them to test this out, and compare to Pat's test map!

@jywarren
Copy link
Member

jywarren commented Oct 1, 2022

Hi!! Just noting i've consolidated the latest information about this feature in this new issue: #1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants