Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cloudns new subdomain: cloud-ip.biz, ip-dynamic.org #2196

Closed
wants to merge 1 commit into from

Conversation

ZedWAre-NEOFTT
Copy link

@ZedWAre-NEOFTT ZedWAre-NEOFTT commented Oct 3, 2024

Public Suffix List (PSL) Submission

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _psl TXT record in place in the respective zone(s).

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • Cloudflare
  • Let's Encrypt
  • MAKE SURE UPDATE THE FOLLOWING LIST WITH YOUR LIMITATIONS! REMOVE ENTRIES WHICH DO NOT APPLY AS WELL AS REMOVING THIS LINE!
  • This request was not submitted with the objective of working around other third-party limits.
  • The submitter acknowledges that it is their responsibility to maintain the domains within their section. This includes removing names which are no longer used, retaining the _psl DNS entry, and responding to e-mails to the supplied address. Failure to maintain entries may result in removal of individual entries or the entire section.
  • The Guidelines were carefully read and understood, and this request conforms to them.
  • The submission follows the guidelines on formatting and sorting.

For PRIVATE section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies and cause other issues, and the rollback timing is acceptable. Proceed anyways.

Description of Organization

As we all know, cloudns provides free second-level domain names to any user. cloudns.ch already existed before. Now cloudns has added a new subdomain name. I also hope that it can be included in the PSL list normally.

Organization Website:

https://www.cloudns.net/

Reason for PSL Inclusion

SEE Description of Organization

Number of users this request is being made to serve:
number of users > 200

DNS Verification

dig +short TXT _psl.cloud-ip.biz https://github.com/publicsuffix/list/pull/2196
dig +short TXT _psl.ip-dynamic.org https://github.com/publicsuffix/list/pull/2196

Results of Syntax Checker (make test)

PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       common.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-public-all
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public
  CCLD     test-is-public-builtin
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
PASS: test-is-public
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.5
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

@wdhdev
Copy link
Contributor

wdhdev commented Oct 4, 2024

@ZedWAre-NEOFTT You do not appear to work for Cloud DNS, therefore you cannot update this section without permission from the author of this section.

Reasons:

  • You used a personal email address to commit this ([email protected]), and not an email that has been used before with this section, nor is it an email associated with Cloud DNS.
  • Neither of the _psl TXT records are in place.
  • You have never contributed to this section before.

Along with those reasons, you have not followed the PR template or PSL guidelines properly either. Your sorting is incorrect, you do not have proper rationale, and the provided user count is too small. You also list you are attempting to get around Cloudflare and Let's Encrypt limitations which is not the intended purpose of the PSL.

I also found this post on Cloudflare's community forum which seems whoever posted it wants to bypass Cloudflare's restrictions, as this PR was opened very soon after.

@boyanpeychev Are you able to confirm or deny whether this person is associated with Cloud DNS? Thank you.

cc @groundcat @simon-friedberger

@dnsguru dnsguru added ❌FAIL - MUST PASS TEST A required acceptance criteria is to run the tests when submitting a PR ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Oct 4, 2024
@groundcat
Copy link
Contributor

These two domains do appear to belong to ClouDNS as seen in their portal; however, as @wdhdev said, only the current registrant (in this case, a requestor authorized by ClouDNS) can submit a new entry for them. Additionally, adding a domain to the PSL has certain technical impacts/implications, so it must be done by the domain registrants themselves.

image

@wdhdev
Copy link
Contributor

wdhdev commented Oct 6, 2024

@dnsguru / @simon-friedberger Can we close this PR, this user isn't associated with the company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ❌FAIL - MUST PASS TEST A required acceptance criteria is to run the tests when submitting a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants