Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OMA-2417] Update dockerfile with java 17 and Android 34 #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[OMA-2417] Update dockerfile with java 17 and Android 34 #202

wants to merge 3 commits into from

Conversation

eros902002
Copy link
Member

I confirm that I have added:

  • A comment to every Dockerfile with information about target repository and tag (version).
  • Filled in readme on dockerhub and in this repo about how to build the image if some extra steps should be done.

@eros902002 eros902002 self-assigned this Nov 29, 2023
abanoubdev
abanoubdev approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@abanoubdev abanoubdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abanoubdev abanoubdev abanoubdev approved these changes

@kartik-moolya kartik-moolya Awaiting requested review from kartik-moolya

Assignees

@eros902002 eros902002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eros902002 @abanoubdev