(self-hosting|2): add minio for local file uploads #974

tefkah · 2025-02-12T17:40:00Z

Issue(s) Resolved

Mostly resolves #954

High-level Explanation of PR

This PR adds minIO, a self-hosted file server with an S3 compatible API, to our docker stack.
This will allow users to host their files on their own server, instead of forcing them to set up an S3 bucket.
It also makes local development and testing a bit nicer for us, as we don't need to use our actual S3 credentials.

Reorganization

I (to my own detriment) reorganized the way the env vars are set for the dev/test compose images a bit. Instead of setting them in the docker-compose.yml, I load them through the corresponding .env.compose.(test|dev).
This makes it slightly easier to manage and override, but also makes it slightly less explicit and more easy to lose track of due to the overriding (i got rid of that as much as possible though).

Let me know if you have any thoughts on this regard. Env var organization is ... annoying.

Test Plan

pnpm dev:setup
Get rid of any S3 config in .env.local if you have any
Go to croccroc, create a submission
Upload a file
Watch it succeed!

Convince yourself that this is a good test

platform/core/playwright/fileUpload.spec.ts

Lines 1 to 133 in c25e50a

    
           import type { Page } from "@playwright/test"; 
        
           import { expect, test } from "@playwright/test"; 
        
           import { FieldsPage } from "./fixtures/fields-page"; 
        
           import { FormsEditPage } from "./fixtures/forms-edit-page"; 
        
           import { FormsPage } from "./fixtures/forms-page"; 
        
           import { LoginPage } from "./fixtures/login-page"; 
        
           import { PubDetailsPage } from "./fixtures/pub-details-page"; 
        
           import { PubTypesPage } from "./fixtures/pub-types-page"; 
        
           import { PubsPage } from "./fixtures/pubs-page"; 
        
           import { createCommunity } from "./helpers"; 
        
           const now = new Date().getTime(); 
        
           const COMMUNITY_SLUG = `playwright-test-community-${now}`; 
        
           const FORM_SLUG = `playwright-test-form-${now}`; 
        
           test.describe.configure({ mode: "serial" }); 
        
           let page: Page; 
        
           test.beforeAll(async ({ browser }) => { 
        
           	page = await browser.newPage(); 
        
           	const loginPage = new LoginPage(page); 
        
           	await loginPage.goto(); 
        
           	await loginPage.loginAndWaitForNavigation(); 
        
           	await createCommunity({ 
        
           		page, 
        
           		community: { name: `test community ${now}`, slug: COMMUNITY_SLUG }, 
        
           	}); 
        
           	/** 
        
           	 * Fill out everything required to make an external form: 
        
           	 * 1. Fields 
        
           	 * 2. Form with fields 
        
           	 * 3. A pub 
        
           	 */ 
        
           	// Populate the fields page with options 
        
           	const fieldsPage = new FieldsPage(page, COMMUNITY_SLUG); 
        
           	await fieldsPage.goto(); 
        
           	await fieldsPage.addFieldsOfEachType(); 
        
           	const pubTypePage = new PubTypesPage(page, COMMUNITY_SLUG); 
        
           	await pubTypePage.goto(); 
        
           	await pubTypePage.addType("File Upload Test", "", ["title", "fileupload"]); 
        
           }); 
        
           test.afterAll(async () => { 
        
           	await page.close(); 
        
           }); 
        
           test.describe("File upload", () => { 
        
           	test("should upload a file", async ({ context }) => { 
        
           		const pubsPage = new PubsPage(page, COMMUNITY_SLUG); 
        
           		await pubsPage.goTo(); 
        
           		const pubId = await pubsPage.createPub({ 
        
           			pubType: "File Upload Test", 
        
           			values: { title: "The Activity of Slugs" }, 
        
           		}); 
        
           		const pubEditUrl = `/c/${COMMUNITY_SLUG}/pubs/${pubId}/edit`; 
        
           		await page.goto(pubEditUrl); 
        
           		await page.setInputFiles("input[type='file']", [ 
        
           			new URL("fixtures/test-assets/test-diagram.png", import.meta.url).pathname, 
        
           		]); 
        
           		// const fileUploadElement = await page 
        
           		// 	.getByRole("button", { name: "browse files", exact: true }) 
        
           		// 	.click({ 
        
           		// 		timeout: 2_000, 
        
           		// 	}); 
        
           		// const fileChooser = await page.waitForEvent("filechooser", (fileChooser) => { 
        
           		// 	return !!fileChooser; 
        
           		// }); 
        
           		// await fileChooser.setFiles( 
        
           		// 	new URL("fixtures/test-assets/test-diagram.png", import.meta.url).pathname 
        
           		// ); 
        
           		await page.getByRole("button", { name: "Upload 1 file", exact: true }).click({ 
        
           			timeout: 2_000, 
        
           		}); 
        
           		await page.getByText("Complete", { exact: true }).waitFor({ 
        
           			timeout: 10_000, 
        
           		}); 
        
           		await page.getByRole("button", { name: "Save" }).click(); 
        
           		await page.getByText("Pub successfully updated", { exact: true }).waitFor({ 
        
           			timeout: 2_000, 
        
           		}); 
        
           		await page.getByRole("link", { name: "View Pub", exact: true }).click(); 
        
           		await page.waitForURL(`/c/${COMMUNITY_SLUG}/pubs/${pubId}`); 
        
           		const fileUploadValue = await page 
        
           			.getByTestId(`FileUpload-value`) 
        
           			.getByRole("button") 
        
           			.click({ 
        
           				timeout: 1_000, 
        
           			}); 
        
           		const describeThing = await page.getByText("Its MIME type is").first().textContent({ 
        
           			timeout: 2_000, 
        
           		}); 
        
           		/** 
        
           		 * So we know the actual file is being uploaded 
        
           		 */ 
        
           		const parsedDescription = describeThing?.match( 
        
           			/The file is (\d+) bytes in size. Its MIME type is (\w+\/\w+)./ 
        
           		); 
        
           		expect(parsedDescription).not.toBeNull(); 
        
           		const fileSize = parsedDescription?.[1]; 
        
           		const mimeType = parsedDescription?.[2]; 
        
           		expect(fileSize).toBeDefined(); 
        
           		expect(parseInt(fileSize!)).toBe(108_839); 
        
           		expect(mimeType).toBe("image/png"); 
        
           		const link = page.getByRole("link", { name: "Open file in new tab" }); 
        
           		const url = await link.getAttribute("href", { timeout: 1_000 }); 
        
           		expect(url).toBeDefined(); 
        
           		await page.goto(url!); 
        
           		await page.waitForURL(/localhost:9000/); 
        
           	}); 
        
           });

Screenshots (if applicable)

Notes

…r allow users to disable email

…nt:' vars using vars from 'env_file'

tefkah · 2025-02-19T09:17:07Z

.github/workflows/e2e.yml

@@ -118,7 +114,7 @@ jobs:
                  INTEGRATION_TEST_HOST: localhost

            - name: Print container logs
-              if: failure()
+              if: ${{failure() || cancelled()}}


if the tests are taking really long to fail and you cancel them, it's nice to be able to see the container logs

tefkah · 2025-02-19T09:17:41Z

core/app/components/forms/FileUpload.tsx

@@ -21,7 +21,7 @@ export function FileUploadPreview({ files }: { files: FileUpload }) {
 									The file is <strong>{file.fileSize}</strong> bytes in size. Its
 									MIME type is <strong>{file.fileType}</strong>.
 								</p>
-								<Button variant="secondary">
+								<Button variant="secondary" asChild>


was for the test, makes clicking this thing more consistent

tefkah · 2025-02-19T09:18:09Z

core/lib/env/env.mjs

@@ -25,6 +25,7 @@ export const env = createEnv({
 		ASSETS_REGION: z.string(),
 		ASSETS_UPLOAD_KEY: z.string(),
 		ASSETS_UPLOAD_SECRET_KEY: z.string(),
+		ASSETS_STORAGE_ENDPOINT: z.string().url().optional(),


the env var that determines whether or not you are using AWS or not

tefkah · 2025-02-19T09:19:05Z

core/lib/server/assets.ts

 	const bucket = env.ASSETS_BUCKET_NAME;

 	const client = new S3Client({
+		endpoint: env.ASSETS_STORAGE_ENDPOINT,
 		region: region,
 		credentials: {
 			accessKeyId: key,
 			secretAccessKey: secret,
 		},
+		forcePathStyle: !!env.ASSETS_STORAGE_ENDPOINT, // Required for MinIO
 	});
 	const command = new PutObjectCommand({
 		Bucket: bucket,


these are all the changes that are necessary to make minIO (or any S3 compatible storage solution) work with our existing setup! isn't that great?

tefkah · 2025-02-19T09:19:46Z

core/playwright.config.ts

+	// don't continue going after 3 tests have failed, that's too many
+	maxFailures: process.env.CI ? 3 : undefined,


maybe controversial. since every single test was failing and retrying 3 times, i'd rather know after 3 tests fail that i'm cooked already

Good change!

tefkah · 2025-02-19T09:20:56Z

core/playwright/fixtures/test-assets/test-diagram.png

isn't it beautiful.

this is just to have something to upload

tefkah · 2025-02-19T09:23:45Z

docker-compose.base.yml

+        entrypoint: >
+            /bin/sh -c '
+            /usr/bin/mc config host add myminio http://minio:9000 "$${MINIO_ROOT_USER}" "$${MINIO_ROOT_PASSWORD}";
+            /usr/bin/mc mb --ignore-existing myminio/"$${ASSETS_BUCKET_NAME}";
+            /usr/bin/mc anonymous set download myminio/"$${ASSETS_BUCKET_NAME}";
+            /usr/bin/mc admin user add myminio "$${ASSETS_UPLOAD_KEY}" "$${ASSETS_UPLOAD_SECRET_KEY}";
+            /usr/bin/mc admin policy attach myminio readwrite --user "$${ASSETS_UPLOAD_KEY}";
+            exit 0;
+            '


it might be better to just have this in a script.

basically what this does:

create the bucket

allow public downloads for said bucket

add a new user

allow said user to upload

this sadly can't be done by just configuring some env vars for minio itself, very annoying, you need to use their mc client. I'm not sure this is the best way to go about doing this.

Could you add this explanation as a comment to the yml file?

tefkah · 2025-02-19T09:24:48Z

docker-compose.dev.yml

-    core:
-        build:
-            context: .
-            args:
-                - PACKAGE=core
-        container_name: core
-        env_file: ./.env.docker-compose
-        environment:
-            #s non secret
-            - ASSETS_BUCKET_NAME=assets.byron.pubpub.org
-            - MAILGUN_SMTP_HOST=smtp.mailgun.org
-            - MAILGUN_SMTP_PORT=465
-            - MAILGUN_SMTP_USERNAME=omitted
-            - OTEL_SERVICE_NAME=core.core
-            - PGDATABASE=postgres
-            - PGHOST=host.docker.internal
-            - PGPORT=54322
-            - PGUSER=postgres
-            - PGPASSWORD=postgres
-            - PUBPUB_URL=http://localhost:8080
-        networks:
-            - app-network
-        ports:
-            - "30000:3000"
-
-    core-nginx:
-        build: ./infrastructure/nginx
-        container_name: core-nginx
-        environment:
-            - NGINX_LISTEN_PORT=8080
-            - NGINX_PREFIX=/
-            - NGINX_UPSTREAM_HOST=core
-            - NGINX_UPSTREAM_PORT=3000
-            - OTEL_SERVICE_NAME=core.nginx
-        depends_on:
-            - core


i removed the core and jobs build services for .dev. I never use them, I don't think any of you use them

tefkah · 2025-02-19T09:26:36Z

package.json

apologies for the format here, prettier seems to go back and forth whether it cares that this file has spaces or tabs. I think it makes sense to just make it the same as everywhere else

tefkah · 2025-02-19T09:27:24Z

packages/schemas/src/formats.ts

 const Url =
-	/^(?:https?|wss?|ftp):\/\/(?:\S+(?::\S*)?@)?(?:(?!(?:10|127)(?:\.\d{1,3}){3})(?!(?:169\.254|192\.168)(?:\.\d{1,3}){2})(?!172\.(?:1[6-9]|2\d|3[0-1])(?:\.\d{1,3}){2})(?:[1-9]\d?|1\d\d|2[01]\d|22[0-3])(?:\.(?:1?\d{1,2}|2[0-4]\d|25[0-5])){2}(?:\.(?:[1-9]\d?|1\d\d|2[0-4]\d|25[0-4]))|(?:(?:[a-z0-9\u{00a1}-\u{ffff}]+-)*[a-z0-9\u{00a1}-\u{ffff}]+)(?:\.(?:[a-z0-9\u{00a1}-\u{ffff}]+-)*[a-z0-9\u{00a1}-\u{ffff}]+)*(?:\.(?:[a-z\u{00a1}-\u{ffff}]{2,})))(?::\d{2,5})?(?:\/[^\s]*)?$/iu;
+	/^(?:https?|wss?|ftp):\/\/(?:\S+(?::\S*)?@)?(?:(?!(?:10|127)(?:\.\d{1,3}){3})(?!(?:169\.254|192\.168)(?:\.\d{1,3}){2})(?!172\.(?:1[6-9]|2\d|3[0-1])(?:\.\d{1,3}){2})(?:[1-9]\d?|1\d\d|2[01]\d|22[0-3])(?:\.(?:1?\d{1,2}|2[0-4]\d|25[0-5])){2}(?:\.(?:[1-9]\d?|1\d\d|2[0-4]\d|25[0-4]))|(?:(?:[a-z0-9\u{00a1}-\u{ffff}]+-)*[a-z0-9\u{00a1}-\u{ffff}]+)(?:\.(?:[a-z0-9\u{00a1}-\u{ffff}]+-)*[a-z0-9\u{00a1}-\u{ffff}]+)*(?:\.(?:[a-z\u{00a1}-\u{ffff}]{2,}))|localhost)(?::\d{2,5})?(?:\/[^\s]*)?$/iu;


very smol modification: allow localhost as a valid host to pass the Url scheme. This was necessary in order to allow local uploads, and also it's just a valid URL

tefkah · 2025-02-19T09:28:37Z

packages/ui/src/customRenderers/fileUpload/fileUpload.tsx

-	uppy.getPlugin<AwsS3Multipart<Meta, AwsBody>>(pluginName)!.setOptions({
-		// TODO: maybe use more specific types for Meta and Body
-		getUploadParameters: async (file) => {
-			if (!file || !file.type) {
-				throw new Error("Could not read file.");
-			}
-			const signedUrl = await props.upload(file.name);
-			return {
-				method: "PUT",
-				url: signedUrl,
-				headers: {
-					"content-type": file.type,
-				},
-			};
-		},
-	});
+	useEffect(() => {
+		uppy.getPlugin<AwsS3Multipart<Meta, AwsBody>>(pluginName)!.setOptions({
+			// TODO: maybe use more specific types for Meta and Body
+			getUploadParameters: async (file) => {
+				if (!file || !file.type) {
+					throw new Error("Could not read file.");
+				}
+
+				if (!file.name) {
+					throw new Error("File name is required");
+				}
+
+				const signedUrl = await props.upload(file.name);
+
+				if (typeof signedUrl === "object" && "error" in signedUrl) {
+					throw new Error(signedUrl.error);
+				}
+
+				return {
+					method: "PUT",
+					url: signedUrl,
+					headers: {
+						"content-type": file.type,
+					},
+				};
+			},
+		});
+	}, [props.upload]);
+


this does not really change the logic (adds two extra checks but that's it)

this should be wrapped in an effect though

tefkah · 2025-02-19T09:29:50Z

packages/ui/src/hover-card.tsx

-	<HoverCardPrimitive.Content
-		ref={ref}
-		align={align}
-		sideOffset={sideOffset}
-		className={cn(
-			"z-50 w-64 rounded-md border bg-popover p-4 text-popover-foreground shadow-md outline-none data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
-			className
-		)}
-		{...props}
-	/>
+	<HoverCardPortal>
+		<HoverCardPrimitive.Content
+			ref={ref}
+			align={align}
+			sideOffset={sideOffset}
+			className={cn(
+				"z-50 w-64 rounded-md border bg-popover p-4 text-popover-foreground shadow-md outline-none data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
+				className
+			)}
+			{...props}
+		/>
+	</HoverCardPortal>


slightly hard to see, but the addition is of the <HoverCardPortal>. Previously the little card that pops up over uploaded files would get obscured by a lot of things, making it hard to click in tests. Now with the portal this is fixed

3mcd

Great work! The environment variable and docker compose changes all look good to me.

tefkah added 24 commits January 27, 2025 19:55

feat: allow local file uploads with minio

6ba77ea

feat: allow different email providers to be used when self-hosting, o…

60758c9

…r allow users to disable email

fix: handle errors and fix types

c3bee15

chore: merge

745ed9f

fix: make minio slightly easier to start

8b17fd8

fix: add upload test

c25e50a

chore: format

fad6bd4

chore: merge

d57d64a

chore: format?

d43f265

fix: get docker compose stuff in reasonable state

2614c9d

fix: hopefully make ci run correctly

3250fc2

fix: env vars?

32c2050

fix: unfix env vars

7db5920

fix: remove unecessary option

a4393ff

fix: shuffle things around more

408e68a

fix: add manual database_url back

e2bb652

fix: don't use non-existint postgres_name var, use postgres_db

e8770ca

fix: log on cancel, and max fail 3 tests

9c7477f

fix: change db url

51b0b38

fix: actually pass in correct env vars this time??

7fb5233

fix: change a bit how i'm doing env vars (shocking)

c3b0357

fix: don't use env.docker-compose in ci directly

8b2f9e4

fix: okay i have learned how env vars work. you cannot set 'environme…

29d413f

…nt:' vars using vars from 'env_file'

fix: minio_root_user instead

1fe827b

tefkah changed the title ~~(self-hosting 2/?): add minio for local file uploads~~ (self-hosting): add minio for local file uploads Feb 19, 2025

tefkah added 2 commits February 19, 2025 10:16

chore: restore dirty

2385cab

docs: update self-host docs

bd4b834

tefkah commented Feb 19, 2025

View reviewed changes

chore: clean up test file

84f73c9

tefkah commented Feb 19, 2025

View reviewed changes

core/playwright/fixtures/test-assets/test-diagram.png Outdated

Copy link

Member Author

tefkah Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it beautiful.

this is just to have something to upload

chore: remove file staged for later commit

a8ea108

tefkah commented Feb 19, 2025

View reviewed changes

tefkah changed the title ~~(self-hosting): add minio for local file uploads~~ (self-hosting|2): add minio for local file uploads Feb 19, 2025

tefkah requested review from kalilsn, 3mcd and allisonking February 19, 2025 09:30

tefkah marked this pull request as ready for review February 19, 2025 09:30

3mcd approved these changes Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(self-hosting|2): add minio for local file uploads #974

(self-hosting|2): add minio for local file uploads #974

tefkah commented Feb 12, 2025 •

edited

Loading

tefkah Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

3mcd Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

3mcd Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

tefkah Feb 19, 2025

3mcd left a comment

	import type { Page } from "@playwright/test";

	import { expect, test } from "@playwright/test";

	import { FieldsPage } from "./fixtures/fields-page";
	import { FormsEditPage } from "./fixtures/forms-edit-page";
	import { FormsPage } from "./fixtures/forms-page";
	import { LoginPage } from "./fixtures/login-page";
	import { PubDetailsPage } from "./fixtures/pub-details-page";
	import { PubTypesPage } from "./fixtures/pub-types-page";
	import { PubsPage } from "./fixtures/pubs-page";
	import { createCommunity } from "./helpers";

	const now = new Date().getTime();
	const COMMUNITY_SLUG = `playwright-test-community-${now}`;
	const FORM_SLUG = `playwright-test-form-${now}`;

	test.describe.configure({ mode: "serial" });

	let page: Page;

	test.beforeAll(async ({ browser }) => {
	page = await browser.newPage();

	const loginPage = new LoginPage(page);
	await loginPage.goto();
	await loginPage.loginAndWaitForNavigation();

	await createCommunity({
	page,
	community: { name: `test community ${now}`, slug: COMMUNITY_SLUG },
	});

	/**
	* Fill out everything required to make an external form:
	* 1. Fields
	* 2. Form with fields
	* 3. A pub
	*/
	// Populate the fields page with options
	const fieldsPage = new FieldsPage(page, COMMUNITY_SLUG);
	await fieldsPage.goto();
	await fieldsPage.addFieldsOfEachType();

	const pubTypePage = new PubTypesPage(page, COMMUNITY_SLUG);
	await pubTypePage.goto();
	await pubTypePage.addType("File Upload Test", "", ["title", "fileupload"]);
	});

	test.afterAll(async () => {
	await page.close();
	});

	test.describe("File upload", () => {
	test("should upload a file", async ({ context }) => {
	const pubsPage = new PubsPage(page, COMMUNITY_SLUG);
	await pubsPage.goTo();
	const pubId = await pubsPage.createPub({
	pubType: "File Upload Test",
	values: { title: "The Activity of Slugs" },
	});

	const pubEditUrl = `/c/${COMMUNITY_SLUG}/pubs/${pubId}/edit`;
	await page.goto(pubEditUrl);

	await page.setInputFiles("input[type='file']", [
	new URL("fixtures/test-assets/test-diagram.png", import.meta.url).pathname,
	]);
	// const fileUploadElement = await page
	// .getByRole("button", { name: "browse files", exact: true })
	// .click({
	// timeout: 2_000,
	// });

	// const fileChooser = await page.waitForEvent("filechooser", (fileChooser) => {
	// return !!fileChooser;
	// });
	// await fileChooser.setFiles(
	// new URL("fixtures/test-assets/test-diagram.png", import.meta.url).pathname
	// );

	await page.getByRole("button", { name: "Upload 1 file", exact: true }).click({
	timeout: 2_000,
	});

	await page.getByText("Complete", { exact: true }).waitFor({
	timeout: 10_000,
	});

	await page.getByRole("button", { name: "Save" }).click();
	await page.getByText("Pub successfully updated", { exact: true }).waitFor({
	timeout: 2_000,
	});

	await page.getByRole("link", { name: "View Pub", exact: true }).click();
	await page.waitForURL(`/c/${COMMUNITY_SLUG}/pubs/${pubId}`);

	const fileUploadValue = await page
	.getByTestId(`FileUpload-value`)
	.getByRole("button")
	.click({
	timeout: 1_000,
	});

	const describeThing = await page.getByText("Its MIME type is").first().textContent({
	timeout: 2_000,
	});

	/**
	* So we know the actual file is being uploaded
	*/
	const parsedDescription = describeThing?.match(
	/The file is (\d+) bytes in size. Its MIME type is (\w+\/\w+)./
	);
	expect(parsedDescription).not.toBeNull();

	const fileSize = parsedDescription?.[1];
	const mimeType = parsedDescription?.[2];

	expect(fileSize).toBeDefined();
	expect(parseInt(fileSize!)).toBe(108_839);
	expect(mimeType).toBe("image/png");

	const link = page.getByRole("link", { name: "Open file in new tab" });

	const url = await link.getAttribute("href", { timeout: 1_000 });

	expect(url).toBeDefined();
	await page.goto(url!);

	await page.waitForURL(/localhost:9000/);
	});
	});

		// don't continue going after 3 tests have failed, that's too many
		maxFailures: process.env.CI ? 3 : undefined,

(self-hosting|2): add minio for local file uploads #974

Are you sure you want to change the base?

(self-hosting|2): add minio for local file uploads #974

Conversation

tefkah commented Feb 12, 2025 • edited Loading

Issue(s) Resolved

High-level Explanation of PR

Reorganization

Test Plan

Screenshots (if applicable)

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

3mcd left a comment

Choose a reason for hiding this comment

tefkah commented Feb 12, 2025 •

edited

Loading