removing the unused created-by-user-id field (#305)

* removing the unused created-by-user-id field

* added a new migration, and cleaned up old created-by-user references

app/controllers/projects_controller.rb

@@ -2,13 +2,11 @@
 class ProjectsController < ApplicationController
   def new
     @project = Project.new
-    @project.created_by_user = current_user
   end
 
   def create
     @project = Project.new
     @project.metadata = form_metadata
-    @project.created_by_user = current_user
     @project.save!
     TigerdataMailer.with(project: @project).project_creation.deliver_later
     redirect_to @project

app/models/project.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 class Project < ApplicationRecord
-  belongs_to :created_by_user, class_name: "User"
-
   def metadata
     (metadata_json || {}).with_indifferent_access
   end
@@ -45,4 +43,8 @@ def update_mediaflux(session_id:)
     ProjectMediaflux.update(project: self, session_id: session_id)
     Rails.logger.debug "Project #{id} has been updated in MediaFlux (asset id #{mediaflux_id}"
   end
+
+  def created_by_user
+    User.find_by(uid: metadata[:created_by])
+  end
 end

db/migrate/20231213164447_remove_created_by_user.rb

@@ -0,0 +1,5 @@
+class RemoveCreatedByUser < ActiveRecord::Migration[7.0]
+  def change
+    remove_column :projects, :created_by_user_id, :integer
+  end
+end

spec/factories/project.rb

@@ -9,9 +9,9 @@
         departments: ["RDSS", "PRDS"],
         directory: "big-data",
         title: FFaker::Movie.title,
-        description: "a random description"
+        description: "a random description",
+        created_by: FactoryBot.create(:user).uid
       }
     end
-    created_by_user_id { FactoryBot.create(:user).id }
   end
 end