Mediaflux status long polling #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcorrea
commented
Jul 26, 2024
| success() { | ||
| const date = new Date(); | ||
| // eslint-disable-next-line no-console | ||
| console.log(`OK - count: ${checkCount} - ${date.toISOString()}`); |
There was a problem hiding this comment.
Leaving this console.log statements so that we can check that it is indeed making the calls and decreasing the frequency the longer the page stays loaded.
hectorcorrea
commented
Jul 26, 2024
| @@ -1,4 +1,2 @@ | |||
| // Import all the channels to be used by Action Cable | |||
| // | |||
|
|
|||
| import './mediaflux_channel'; | |||
There was a problem hiding this comment.
This PR replaces the WebSockets/ActionCable implementation with a plain AJAX call with long polling.
hectorcorrea
force-pushed
the
mediaflux-status-long-polling
branch
from
88a1cfa to
791aa27
Compare
hectorcorrea
commented
Jul 29, 2024
| @@ -6,12 +6,12 @@ | |||
| </a> | |||
| <div class="mediaflux"> | |||
| Mediaflux Status | |||
| <div class="mediaflux-status inactive"></div> | |||
| <div class="mediaflux-status unknown"></div> | |||
There was a problem hiding this comment.
Display a brown circle when we have not checked the status (e.g. for a not logged in user)
|
Closing now that #862 is working in staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that this PR is a draft. If James' work with WebSockets works in staging we won't need this PR, if it does not then this PR is a good backup plan.
Uses JavaScript long polling to check the status of Mediaflux. We check the status every 2 seconds when a page is loaded, and the longer the page stays loaded we slow down the checks (every 10 seconds, and then every 30 seconds). We could tweak these settings as we wish.
Below is an example on how this looks in staging: