Bender: Bump AXI-REALM and fix AXI-REALM functional tests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex96295
force-pushed
the
aottaviano/realm-eval
branch
from
65d53fd
to
6f78017
Compare
Aquaticfuller
pushed a commit
that referenced
this pull request
Jul 16, 2024
Bender: Bump `axi_rt` AXI real-time unit
* Fix functional bug
alex96295
force-pushed
the
aottaviano/realm-eval
branch
2 times, most recently
from
321dcd6
to
e465b87
Compare
alex96295
force-pushed
the
aottaviano/realm-eval
branch
3 times, most recently
from
4e3a22a
to
1fd8e20
Compare
* Fix expected left budget (W/R) calculation * Extend to support multiple CVA6 cores
* Check successful manager isolation after running out of budget
Add `axirt_budget_isolate` test to CI
alex96295
force-pushed
the
aottaviano/realm-eval
branch
from
1fd8e20
to
82b64c4
Compare
alex96295
changed the title
paulsc96
requested changes
Oct 23, 2024
There was a problem hiding this comment.
I can't speak on the tests, it's best to talk that over with @thommythomaso.
The nonfree change is fine and has been merged.
I just have one small comment below.
Comment on lines
+54
to
+62
|
|
||
| // IDs for AXI-REALM managers | ||
| // Adjust if more CVA6 cores, default to 1 | ||
| enum axirealm_mngr_id { | ||
| AXIREALM_MNGR_ID_CVA60 = 0, | ||
| AXIREALM_MNGR_ID_DBG = 1, | ||
| AXIREALM_MNGR_ID_DMA = 2, | ||
| AXIREALM_MNGR_ID_SL = 3 | ||
| }; |
There was a problem hiding this comment.
We shouldn't hardcode things we know are parameterization-specific here.
Instead, you can read the num_int_harts register to know how many internal harts there are and hw_features to know which hardware features are available.
There was a problem hiding this comment.
Makes sense, I already use the num_int_harts in the test. Will fix this ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump AXI-REALM to latest version. Fixes functional bug.
Depends on: https://iis-git.ee.ethz.ch/pulp-restricted/cheshire-nonfree/-/merge_requests/16