Skip to content

Commit

Permalink
ci: Disable stale and fail on formatting issues (#45)
Browse files Browse the repository at this point in the history
* ci: Deactivate stale workflow

* ci: Report formatting issues in github checks and fail

This lets the verible fail if there are any formatting issues reported.
This help to
- detect formatting issues soon (before opening a PR),
- clearly mark checks failed for uncompliant changes.

---------

Signed-off-by: Nils Wistoff <[email protected]>
  • Loading branch information
niwis authored and paulsc96 committed Oct 18, 2024
1 parent 85bd108 commit 858dc18
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

name: 'Close stale issues and PRs'
on:
workflow_dispatch:
schedule:
- cron: '30 1 * * *'
workflow_dispatch
# schedule:
# - cron: '30 1 * * *'

jobs:
stale:
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/verible.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
# SPDX-License-Identifier: Apache-2.0

name: Verible
on:
pull_request_target:
on: [push, pull_request_target]

jobs:
format:
Expand All @@ -17,7 +16,10 @@ jobs:
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: chipsalliance/verible-formatter-action@main
- uses: niwis/verible-formatter-action@pulp
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
files: '$(find core -regex ".*\.\(v\|sv\)$" | grep -v "^core/include/.*_config_pkg.sv$")'
fail_on_formatting_suggestions: false
reviewdog_reporter: github-check
reviewdog_fail_on_error: true

0 comments on commit 858dc18

Please sign in to comment.