Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Prevent spurious interrupts from being generated when in CLIC mode #32

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

ezelioli
Copy link

@ezelioli ezelioli commented Jul 4, 2023

Spurious interrupts are generated when running in CLIC mode. The else branch of the if condition should not be executed when running in CLIC mode, regardless of whether an interrupt is pending or not.

@ezelioli ezelioli requested a review from niwis as a code owner July 4, 2023 17:13
Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, LGTM

@niwis niwis merged commit 31f6452 into pulp-platform:pulp Jul 23, 2023
13 checks passed
maxbjurling added a commit to planvtech/cva6_pulp that referenced this pull request Oct 11, 2023
* Fix syntax incompatibilities

 - Add CVA6ConfigDcacheCoherent configuration parameter

 - Propagate sizing parameters (AXI_DATA_WIDTH, DCACHE_LINE_WIDTH) into
   ace_ccu_top

* Bump ace version

* Add parameter for ACE support

* Various minor code fixes

---------

Co-authored-by: Max Bjurling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants