Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Take all CLIC interrupts when in U-mode #33

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ezelioli
Copy link

@ezelioli ezelioli commented Jul 4, 2023

When running in User mode, interrupts should be considered always globally enabled for S and M modes.

@ezelioli ezelioli requested a review from niwis as a code owner July 4, 2023 17:19
@bluewww bluewww self-requested a review July 14, 2023 12:54
@bluewww
Copy link

bluewww commented Jul 14, 2023

I believe this is correct

Copy link
Collaborator

@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niwis niwis merged commit 11264e5 into pulp-platform:pulp Jul 24, 2023
13 checks passed
niwis pushed a commit that referenced this pull request Apr 25, 2024
* Wait with new request until critical word arrives

* Add dcache_intf.req

* Update unit test

 - Add incremental id to all dcache requests for easier debug

 - Wait for dcache grant (if requested) in do_hit()

 - Call do_hit() after readback in do_miss()

 - Wait for MSHR match before calling do_hit() or do_miss() in
   check_cache_msg()

 - Don't call do_miss() on changed cache state in update_cache_from_req()

* Add option to distinguish between cache ports via AXI ID

* Select dcache AXI for any ID in range [1100,1111]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants