Gvsoc ci #142
Draft
Gvsoc ci #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haugoug
requested review from
colluca,
fischeti,
viv-eth and
paulsc96
as code owners
colluca
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Thanks for the contribution @haugoug!
I have a few major comments:
- To add the GVSoC tests to the CI the workflow file needs to be adapted as well, see
snitch_cluster/.github/workflows/ci.yml
Line 47 in e90dceb
- For all tests which make use of the IPC verification interface (i.e. those which have no BIST verification), just running the binaries with GVSoC doesn't really check anything. Perhaps we want to extend the IPC verification interface to work also with GVSoC, otherwise we just need to make clear that the GVSoC simulation will not really verify those tests.
Minor comments follow on the code.
Comment on lines
+99
to
+113
| class GvsocSimulator(RTLSimulator): | ||
| """Gvsoc simulator | ||
|
|
||
| An [RTL simulator][Simulator.RTLSimulator], identified by the name | ||
| `vsim`, tailored to the creation of | ||
| [Gvsoc simulations][Simulation.GvsocSimulation]. | ||
| """ | ||
|
|
||
| def __init__(self, binary): | ||
| """Constructor for the GvsocSimulator class. | ||
|
|
||
| Arguments: | ||
| binary: The Gvsoc simulation binary. | ||
| """ | ||
| super().__init__(binary, name='gvsoc', simulation_cls=GvsocSimulation) |
There was a problem hiding this comment.
Why does it inherit from the RTLSimulator class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.