Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snDNN: Move kernels into library compatible with new Runtime #26

Merged
merged 17 commits into from
Aug 21, 2023
Merged

snDNN: Move kernels into library compatible with new Runtime #26

merged 17 commits into from
Aug 21, 2023

Conversation

paulsc96
Copy link
Collaborator

Reopen of #5.

viv-eth
viv-eth requested changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@viv-eth viv-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torch module is missing the requirements.txt. Can you add it? I think then tests will pass

@GiannaP
Copy link
Contributor

GiannaP commented Jul 20, 2023

torch module is missing the requirements.txt. Can you add it? I think then tests will pass

I had to re-build the docker on the specific branch such that the newest snDNN requirements are installed on Docker.

@GiannaP
Copy link
Contributor

GiannaP commented Jul 20, 2023

After the re-base on the newest master, the simulation of fusedconv reports errors. Therefore, I have removed it from the list called sw/apps/passing-apps.list that is executed in the CI.

@GiannaP GiannaP force-pushed the snDNN branch 2 times, most recently from bb30b81 to 621acee Compare July 26, 2023 15:49
@viv-eth viv-eth merged commit ca5e744 into main Aug 21, 2023
25 checks passed
@viv-eth viv-eth deleted the snDNN branch August 21, 2023 12:20
@colluca colluca mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viv-eth viv-eth viv-eth approved these changes

@colluca colluca Awaiting requested review from colluca colluca is a code owner

@fischeti fischeti Awaiting requested review from fischeti fischeti is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulsc96 @GiannaP @viv-eth @colluca