Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

banshee: Fix Banshee runtime support and add tests #31

Merged
merged 12 commits into from
Aug 8, 2023
Merged

banshee: Fix Banshee runtime support and add tests #31

merged 12 commits into from
Aug 8, 2023

Conversation

GiannaP
Copy link
Contributor

@GiannaP GiannaP commented Jul 28, 2023 •
edited
Loading

  • fix Banshee runtime
  • add small documentation on dependency tools (banshee, bender, spike)
  • run all existing tests with Banshee and check the passing and failing ones
  • add tests to Github CI
  • add tests to Gitlab CI
  • Fix VCS and VLT simulation setup

TODO:

  • banshee repo: Make flexfloat submodule based on https instead of ssh for simplified docker recursive repository checkout

@GiannaP GiannaP force-pushed the banshee branch 23 times, most recently from 87eb7e4 to 3bf1025 Compare August 3, 2023 09:34
@GiannaP GiannaP marked this pull request as ready for review August 3, 2023 10:05
paulsc96
paulsc96 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM

target/snitch_cluster/README.md Outdated Show resolved Hide resolved
colluca
colluca reviewed Aug 3, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
colluca
colluca reviewed Aug 3, 2023
View reviewed changes
.gitlab-ci.yml Show resolved Hide resolved
colluca
colluca reviewed Aug 3, 2023
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
colluca
colluca reviewed Aug 3, 2023
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
colluca
colluca reviewed Aug 3, 2023
View reviewed changes
docs/ug/getting_started.md Outdated Show resolved Hide resolved
colluca
colluca reviewed Aug 3, 2023
View reviewed changes
sw/snRuntime/src/start.c Outdated Show resolved Hide resolved
@colluca colluca merged commit 1183399 into main Aug 8, 2023
25 checks passed
@colluca colluca deleted the banshee branch August 8, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colluca colluca colluca left review comments

@paulsc96 paulsc96 paulsc96 approved these changes

@fischeti fischeti Awaiting requested review from fischeti fischeti is a code owner

@viv-eth viv-eth Awaiting requested review from viv-eth viv-eth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiannaP @colluca @paulsc96