fix: the resumeOnRestart function to handle correctl the recurring jobs + do not run finished non-recurrent jobs on restart + add unit tests

[b0dea]

Hi,

This PR hopes to solve some/all problems that have been flagged under these issues

• Pulse re-runs finished jobs after a process restart #57 - I have experienced it also
• ResumeOnRestart reprocess already recurrent jobs  #55 - I have experienced it also
• resumeOnRestart: Successful jobs never get restarted #54 - I have experienced it also

So, I'm proposing some changes to improve how resumeOnRestart works, ensure we’re handling all types of jobs correctly, and fix issues around rescheduling non-recurring jobs that shouldn’t be run again (on restart).

What’s Changed?

1. Improved resumeOnRestart

   • Non-recurring jobs:
     • Added a strong(er) check when searching for non-recurring jobs to search for both non-existent lastFinishedAt but also cover the case in which it is null
   • Recurring jobs:
     • Add proper search for the unfinished recurrent jobs and then reschedule them using the computeNextRunAt function.

2. Adjusted Job Model nextRunAt default - If a non-recurring jobs is completed (lastFinishedAt exists), we should preserve the set nextRunAt (if it was set explicitly) and we should do not default it to new Date() (which triggers a re-run). For the recurrent jobs, we can keep what has been done before (either nextRunAt or new Date()).

3. Added Test Cases to check as much as we can if resumeOnRestart works properly

Let me know if you spot any edge cases or mistakes I need to fix.

[code-xhyun]

🎉 This PR is included in version 1.6.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀