Organise template directories #1346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielrbradley
commented
Feb 3, 2025
•
danielrbradley
commented
- Flatten the dev-container config into the general provider internal template. This adds the dev-container support to the "generic" providers.
- Rename internal template directory names for clarity so they're only a single word:
- Rename "provider" to "base"
- Rename "pulumi-provider" to "internal"
- Rename "external-provider" to "external"
- Rename "bridged-provider" to "bridged"
We don't need a separate internal template for dev-containers. This can just be part of the base provider template. This adds the dev container to "generic" providers where it should also be available.
Make purpose of separation clearer.
thomas11
approved these changes
Feb 3, 2025
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
Yup ... from #721
- add an empty devbox.lock file to the bridged provider template so that the devcontainer will build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.