Enable zero default schema version in AWS #4646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
requested review from
t0yv0,
flostadler,
guineveresaenger,
iwahbe and
corymhall
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
|
I know this has been taken through many providers for soaking, but I am still slightly worried that this fix extends the reach of pulumi/pulumi-terraform-bridge#1667 related bugs. Does it fix some known issues in AWS or we just take it on preemptively? I'd be a lot more comfortable fixing 1667 first and then shipping this, but if it fixes known issues that'd be good reason to maybe rush it. |
|
@flostadler for a second opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll out pulumi/pulumi-terraform-bridge#2081 to AWS.
Part of pulumi/pulumi-terraform-bridge#2133