-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding PATCH vs PUT for updates of select resources #3983
Draft
thomas11
wants to merge
6
commits into
master
Choose a base branch
from
tkappler/customize-patch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
2b15e00
to
4d3d97e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3983 +/- ##
==========================================
+ Coverage 57.49% 57.51% +0.02%
==========================================
Files 82 82
Lines 13078 13092 +14
==========================================
+ Hits 7519 7530 +11
- Misses 4984 4986 +2
- Partials 575 576 +1 ☔ View full report in Codecov by Sentry. |
… testing for create/update operations
…not recreate the server
4d3d97e
to
b9c21a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: since there are resources where PATCH is also the Create method, this PR doesn't work as is. We cannot express three options with one boolean
UpdateMethod
:Currently, every resource where the spec defines a PUT operation is created and updated via PUT. This is incorrect for a small number of resources which should be created via PUT but updated via PATCH. Postgres Server, e.g., will be recreated when updated via PUT when certain properties are changed.
This PR decouples determining the create and the update operation for a resource. It splits
CreateOrUpdate
of the Azure client intoCreate
andUpdate
. An addition to the Postgres integration test shows that the password of a server can now be updated without replacement.Resolves #3961