Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2 Instance State #2874

Draft
wants to merge 1 commit into
base: vvm/remove_v2_resource_and_resource_map
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 39.24%. Comparing base (73d9a82) to head (28adf4d).

Files with missing lines Patch % Lines
pkg/tfshim/sdk-v2/provider2.go 0.00% 6 Missing ⚠️
pkg/tfshim/sdk-v2/provider.go 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (73d9a82) and HEAD (28adf4d). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (73d9a82) HEAD (28adf4d)
13 10
Additional details and impacted files
@@                             Coverage Diff                             @@
##           vvm/remove_v2_resource_and_resource_map    #2874      +/-   ##
===========================================================================
- Coverage                                    46.21%   39.24%   -6.97%     
===========================================================================
  Files                                          304      304              
  Lines                                        40214    40148      -66     
===========================================================================
- Hits                                         18583    15757    -2826     
- Misses                                       19984    22895    +2911     
+ Partials                                      1647     1496     -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_instance_state branch from c42aa85 to ee2b549 Compare January 28, 2025 14:37
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch from 983fc70 to a86d57d Compare January 28, 2025 14:47
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_instance_state branch from ee2b549 to 2a0b172 Compare January 28, 2025 14:47
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch from a86d57d to 96fc258 Compare January 28, 2025 14:54
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_instance_state branch from 2a0b172 to 23d7530 Compare January 28, 2025 14:54
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch from 96fc258 to f1f7af1 Compare January 28, 2025 15:27
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_instance_state branch from 23d7530 to 2a271b2 Compare January 28, 2025 15:27
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch from f1f7af1 to 73d9a82 Compare January 28, 2025 15:34
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_instance_state branch from 2a271b2 to 28adf4d Compare January 28, 2025 15:34
@VenelinMartinov VenelinMartinov marked this pull request as draft January 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant