Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix all gosec Security Issues #43

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix: Fix all gosec Security Issues #43

merged 4 commits into from
Dec 31, 2024

Conversation

soorya-u
Copy link
Collaborator

No description provided.

@puneeth072003
Copy link
Owner

puneeth072003 commented Dec 31, 2024 •
edited
Loading

@soorya-u i think we should modify the worklow to actually install depenedencies first (in both services ig) to get this working

@soorya-u
Copy link
Collaborator Author

@soorya-u i think we should modify the worklow to actually install depenedencies first (in both services ig) to get this working

yea...apart from that...the security issues are fixed

@puneeth072003 puneeth072003 linked an issue Dec 31, 2024 that may be closed by this pull request
fix: make code changes to conform with gosec #17
Closed
@puneeth072003
Copy link
Owner

@soorya-u i think we should modify the worklow to actually install depenedencies first (in both services ig) to get this working

yea...apart from that...the security issues are fixed

Yes but worklfow is failing we need to fix that for further runs

@puneeth072003
Copy link
Owner

puneeth072003 commented Dec 31, 2024 •
edited
Loading

@soorya-u please cache previous depenedencies to that it doesn't take up much of CI minutes everytime

@soorya-u
Copy link
Collaborator Author

@soorya-u please cache previous depenedencies to that it doesn't take up much of CI minutes everytime

Done

@puneeth072003
Copy link
Owner

@soorya-u you are good to go, good work!!!

@puneeth072003
Copy link
Owner

once after merging check the workflow is passing or not

@puneeth072003
Copy link
Owner

you might need to make series of changes if not

@soorya-u soorya-u merged commit fe70f9f into puneeth072003:main Dec 31, 2024
1 check failed
@soorya-u soorya-u deleted the fix/gosec-issue branch December 31, 2024 06:39
puneeth072003
puneeth072003 approved these changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@puneeth072003 puneeth072003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneeth072003 puneeth072003 puneeth072003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: make code changes to conform with gosec
2 participants
@soorya-u @puneeth072003