Use Ansible local facts for OS-specific variables #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellienert
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the PHP version variable is constructed dynamically depending on which PHP version is installed on the target system:
https://github.com/punktDe/ansible-proserver-php/blob/master/tasks/phpversion.yaml#L7-L20
Unfortunately, if this task is not ran explicitly (e.g. because of
--start-at-task), thephp_versionvariable will remain empty.Moreover, with the recent change in the PHP service name on FreeBSD, we also need to construct the variable representing the PHP service dynamically, depending on the blueprint version.
Using ansible_local facts instead of a
set_facttask ensures that the necessary variables are generated on the target system instead, and are available at any point in the playbook viaansible_local.php