(PE-38522) Add install_puppet_agent_pe_promoted_repo_on #277
Conversation
|
I cleaned up the commit and the whitespace. This passes when I run the beaker tests locally. |
There was a problem hiding this comment.
The solaris_install_local_package, install_local_package and uncompress_local_package all exist in Beaker::Host modules still. My initial thought is that we should still be using those rather than duplicating the methods here, unless something else is blocking that.
lib/beaker-pe/install/pe_utils.rb
Outdated
| @@ -891,6 +891,245 @@ def config_hosts_for_proxy_access hosts | |||
| end | |||
| end | |||
|
|
|||
| # removes the install_puppet_agent_pe_promoted_repo_on method | |||
|
|
|||
| # Install shared repo of the puppet-agent on the given host(s). Downloaded from | |||
There was a problem hiding this comment.
This rubydoc block I think got separated from its method.
There was a problem hiding this comment.
I think you deleted this rubydoc block rather than reattaching it to its method install_puppet_agent_pe_promoted_repo_on, I believe.
|
|
Nothing is blocking that as far as I know. I'll remove the redundancy |
|
Noted a few more items above, and then the commit message needs to catch up with the rest of your changes. |
tlehman
force-pushed
the
PE38522
branch
2 times, most recently
from
bc4e463
to
c1f07fb
Compare
|
The rubydoc for install_puppet_agent_pe_promoted_repo_on is still missing, but other than that I think it's sorted out. |
See https://perforce.atlassian.net/browse/PE-38522 for details These methods were removed from Host with this commit: tlehman/beaker@cdaedad - pe_puppet_agent_promoted_package_info_(mac|unix|windows) - pe_puppet_agent_promoted_package_install_(mac|unix) - install_puppet_agent_pe_promoted_repo_on Instead of adding the methods back onto Host (which lives in beaker), I copied these methods to beaker-pe, and then changed the `self` reference to an explicit `host` reference that is passed in as a parameter.
See https://perforce.atlassian.net/browse/PE-38522 for details
These methods were removed from Host with this commit: tlehman/beaker@cdaedad
Instead of adding the methods back onto Host (which lives in beaker), I copied these
methods to beaker-pe, and then changed the
selfreference to an explicithostreference that is passed in as a parameter.